Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system proxy as a pre-built proxy servers #344

Open
fonlan opened this issue Feb 26, 2024 · 14 comments
Open

Add system proxy as a pre-built proxy servers #344

fonlan opened this issue Feb 26, 2024 · 14 comments
Labels
status-needs-info More information is needed type-new-feature Adding a new feature

Comments

@fonlan
Copy link

fonlan commented Feb 26, 2024

Description

Company use a PAC script as the default system proxy. And I know SmartProxy will not support PAC.
So is it possible add system proxy as a pre-built proxy server? So I can choice it as the default proxy.

Is your feature request related to a problem? Please describe.

Currently I can't use SmartProxy in my company's environment because it's not support PAC. Add system proxy as a pre-built proxy servers can be a solution.

Describe alternatives you've considered

No response

Any additional context

No response

@fonlan fonlan added the type-new-feature Adding a new feature label Feb 26, 2024
@salarcode
Copy link
Owner

I don't understand what you mean by "system proxy as a pre-built proxy servers"!
You can create different profiles and have them point to different proxy servers:
https://github.com/salarcode/SmartProxy/wiki/Add-New-Smart-Profile

@salarcode salarcode added the status-needs-info More information is needed label Feb 26, 2024
@fonlan
Copy link
Author

fonlan commented Feb 26, 2024

The "system proxy" I means the proxy configured in windows setting like below.
image

Currently I can't create proxy server profile point to windows system proxy setting.

@salarcode
Copy link
Owner

The option "System Proxy" should do that for you.
That will tell browser to use whatever proxy is configured in windows. And because there is only one Windows you are using to run the browser there will be only one System profile, no more!

@fonlan
Copy link
Author

fonlan commented Feb 26, 2024

But the option "System Proxy" will only use the proxy configured in windows setting.
What I need is use dedicate proxy profile if domain exist in rule list. If domain not match any rule, use "System Proxy".

@jackyzy823
Copy link
Contributor

What I need is use dedicate proxy profile if domain exist in rule list. If domain not match any rule, use "System Proxy".

I guess that:

If you're using firefox , i guess you could set using system proxy in the browersettings . https://support.mozilla.org/en-US/kb/connection-settings-firefox.

And then set the domain you want to proxy in "SmartProxy".

Reference: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo#type_2

"direct": don't proxy the request. If this value is given, all other properties of this object are ignored. However, this setting doesn't override any proxy set by the user. Use proxy.settings to check whether a manual proxy is being used and, if necessary, monitor those settings for changes using BrowserSetting.onChange.

Chrome might be same.

@salarcode
Copy link
Owner

salarcode commented Feb 26, 2024

What I need is use dedicate proxy profile if domain exist in rule list. If domain not match any rule, use "System Proxy".

I guess that:

If you're using firefox , i guess you could set using system proxy in the browersettings . support.mozilla.org/en-US/kb/connection-settings-firefox.

And then set the domain you want to proxy in "SmartProxy".

Reference: developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo#type_2

"direct": don't proxy the request. If this value is given, all other properties of this object are ignored. However, this setting doesn't override any proxy set by the user. Use proxy.settings to check whether a manual proxy is being used and, if necessary, monitor those settings for changes using BrowserSetting.onChange.

Chrome might be same.

Thanks for your reply but description for "direct" is misleading. proxy set by the user is grayed out and not accessible for user when there is a proxy extension.

@salarcode
Copy link
Owner

But the option "System Proxy" will only use the proxy configured in windows setting. What I need is use dedicate proxy profile if domain exist in rule list. If domain not match any rule, use "System Proxy".

Why you want is basically is this: Use the PAC when there is matching rule!

I don't see a value in this and we don't want to cover all the edge cases

@fonlan
Copy link
Author

fonlan commented Feb 27, 2024

But the option "System Proxy" will only use the proxy configured in windows setting. What I need is use dedicate proxy profile if domain exist in rule list. If domain not match any rule, use "System Proxy".

Why you want is basically is this: Use the PAC when there is matching rule!

I don't see a value in this and we don't want to cover all the edge cases

The key point is not the PAC. I means use system proxy when there is NO matching rule.
When I use SmartProxy "System Proxy" option, will it check rule matching?

@jackyzy823
Copy link
Contributor

Using system proxy with PAC , means you should following all PAC rules, and there's definitely a rule in PAC which asking all non-matching rules to use "DIRECT".


I'd suggest to extract rules and proxies from pac file and filled into smartproxy rules and proxies.

Then add rules for non-mathcing domains.

@salarcode
Copy link
Owner

salarcode commented Feb 27, 2024

One Idea I get from this is allowing behaviour configuration of Smart Rules profile when there is no matching rule:

  • Use no proxy (default)
  • Use system proxy (new option)

This should be easy to implement but not sure how useful is for people!

@fonlan
Copy link
Author

fonlan commented Feb 27, 2024

Using system proxy with PAC , means you should following all PAC rules, and there's definitely a rule in PAC which asking all non-matching rules to use "DIRECT".

I'd suggest to extract rules and proxies from pac file and filled into smartproxy rules and proxies.

Then add rules for non-mathcing domains.

The problem for this solution is the PAC is managed by company and we can't modify it by ourself. And there are too many rules in PAC and always updating by IT. Manually extract rules and fill into smartproxy seems not a good idea.

@fonlan
Copy link
Author

fonlan commented Feb 27, 2024

One Idea I get from this is allowing behaviour configuration of Smart Rules profile when there is no matching rule:

  • Use no proxy (default)
  • Use system proxy (new option)

This should be easy to implement but not sure how useful is for people!

Yes. That's enough for me. It's a good solution. Thank you!

@salarcode
Copy link
Owner

One Idea I get from this is allowing behaviour configuration of Smart Rules profile when there is no matching rule:

  • Use no proxy (default)
  • Use system proxy (new option)

This should be easy to implement but not sure how useful is for people!

Yes. That's enough for me. It's a good solution. Thank you!

After some checking sorry to say that this is not possible in Chrome due its stupid limited api

@fonlan
Copy link
Author

fonlan commented Feb 27, 2024

☹️ Ok, seems impossible now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-needs-info More information is needed type-new-feature Adding a new feature
Projects
None yet
Development

No branches or pull requests

3 participants