Refactor components to decouple them #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Higher Order Component WithSelectedBlock, which passes the prop "block" into its child, where the value of the "block" prop is the JavaScript object for the currently selected block.
Modify BlockXray to take "block" as a prop, instead of doing the lookup inside the BlockXray component.
salcode
force-pushed
the
feat/refactor-components-to-decouple-11
branch
from
9793b98
to
900e975
Compare
salcode
force-pushed
the
feat/refactor-components-to-decouple-11
branch
from
900e975
to
93b20f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change in this PR is moving the data lookup into a Higher Order Component (
WithSelectedBlock), the rest of the changes are renaming and reorganizing based on this change.Resolves #11