Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Improve offline placeholder component #92

Closed
dominik-zeglen opened this issue Oct 31, 2018 · 5 comments
Closed

Improve offline placeholder component #92

dominik-zeglen opened this issue Oct 31, 2018 · 5 comments
Labels

Comments

@dominik-zeglen
Copy link
Contributor

I just don't think that rendering OFFLINE :( is a good idea here.

@pwgryglak
Copy link

I've added placeholder component to the UI guide

@maarcingebala
Copy link
Member

Currently, a page that hasn't loaded due to offline mode and missing data renders like that:
image

@pwgryglak I can see on figma that we have a placeholder for missing image ("Photo unavailable"). Are you referring to that one or is there any other design for an entire page that is unavailable due to offline?

@pwgryglak
Copy link

@maarcingebala
If you're referring to placeholder image you can find in storefront UI guide then it is the one to use yes. No there is no specific page referring to missing images. If you need it I can prepare it.

@stale
Copy link

stale bot commented Nov 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 19, 2019
@maarcingebala
Copy link
Member

maarcingebala commented Nov 20, 2019

Should be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants