Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Internal Server Error instead of a validation error on too long inputs #12696

Open
typeofweb opened this issue Apr 27, 2023 · 4 comments · May be fixed by #13608
Open

Bug: Internal Server Error instead of a validation error on too long inputs #12696

typeofweb opened this issue Apr 27, 2023 · 4 comments · May be fixed by #13608
Labels
bug good first issue Good first issues payments Issues related to payments implementation

Comments

@typeofweb
Copy link
Contributor

What are you trying to achieve?

When transaction event description or pspReference is above 512 characters, Internal Server Error is returned instead of some kind of validation error.

Steps to reproduce the problem

https://master.staging.saleor.cloud/graphql/#saleor/N4IgjiBcILYK4BcCGCCWB7AdgAgMICcBTFQgWSUziQBsAVfCgZyQGM0tckAHBOIgCgAk6fABNC+AJKjI2SQBEAhABpsgpDHRxMCWQAV0jVGgBuheYRaoYNFWpZ8imFgE9ZAZQT5UmAOZ3BcUYWbx4MTA8vH19VQS5GLgAlQgAzCUJnQkjvPwBKbGAAHRxsLyZWdkwCYgRCfmLsbFQZNRFxKVEG0oZMZjZw2WAEFy4s7EKQckoabBZuXiIJ1UZkXkZZCfc4FhZCRkYl7Hik1PTM2TiE5LSnXdUNLR1cAAskfF9CFuAH7V01H50qgc+FubnsjgyrgAvlCumVehVwgBRMw6QYrFBwdbYdwAVVwuCR7ncqmO1zOuwuZNOt0IqkwGjGgT2IVQYSwsMw+SKJUaEnwIkYBS6jUaKVQhGonV5opge2YHxFopY6HESs5hQQnM5IGUIHQUBA1RIUyodB6fUqnB4fEIupAJkNPMaE2BoImGxAuPc8iWXQmbQk0g94xAtAAzAApADWAC0ABqSABsAHl5ABFAAspBgiRgAE0YEiECmAOLpgAepBcAAYawA5WjUGAAGQA6pIGwArACCCHzXZY4dI8hYAEZG0ia6Ryy4-SUJgCECGx8p-SAgqz2ZgQxMa2OAEzhzMAViTAHYABwATiQACMWOIUvuj6eLzf74-Ui-j2er7eHyfH833-T8gMPX93wAr9nwgkCP0A784L-BCYOAlDoPA18MLApDsKg3DYPw0DEKIyCSLQ5CCNI9DqMo4jUKw8jGLw5jMNY+D2LIzjCNoiimJ4miqP4jicKEhiuL4ljuLE+i2N44TpKkyTFJUiSFPU0ikHnF0QGpG5IUIXcQGUjT5PE8y5MEqzZIE2zRLouzHIckSZOctzXNMizrKczzVLMnyXKU-zvPsjzgs0mz3K8qK-Mi3yIsshK1KSoKUsC8KuO0kBih1KEgA

What did you expect to happen?

Validation error.

Logs

No response

Environment

Saleor version: master.staging
@maarcingebala
Copy link
Member

API is missing validation and tries to put that value to DB without checking its length, while the DB field has a 512 chars limit. Sentry log: https://saleor.sentry.io/issues/4128212843/events/a5db9b6a7e8b4d8795507fce26c691f1/

@maarcingebala maarcingebala added the payments Issues related to payments implementation label May 15, 2023
@maarcingebala
Copy link
Member

@korycins Maybe it's a quick fix, can you take a look?

@Droniu Droniu mentioned this issue May 15, 2023
Open
@korycins
Copy link
Member

@korycins Maybe it's a quick fix, can you take a look?

@maarcingebala I will handle this in the meantime

@korycins korycins self-assigned this May 26, 2023
@maarcingebala maarcingebala added the good first issue Good first issues label Jun 13, 2023
@ssuraliya
Copy link
Contributor

I'll take this one.

@ssuraliya ssuraliya linked a pull request Aug 2, 2023 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Good first issues payments Issues related to payments implementation
Projects
None yet
Milestone
No milestone
4 participants
@typeofweb @maarcingebala @korycins @ssuraliya