Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip updating search when changed DB columns do not affect results #14320

Open
NyanKiyoshi opened this issue Oct 16, 2023 · 0 comments
Open

Skip updating search when changed DB columns do not affect results #14320

NyanKiyoshi opened this issue Oct 16, 2023 · 0 comments

Comments

@NyanKiyoshi
Copy link
Member

When mutations such as productUpdate() are invoked, the product's search vector
should only be updated if it's actually changing columns that are saved as part of the
search vector, such as: product name, description, attributes, etc.1

For example, product metadata are not search indexed and thus shouldn't lead to
a product re-indexing.

Every mutation that causes to update search indexes should be reviewed, and optimized.

Solving this issue would reduce resources needed and costs.

Footnotes

  1. https://github.com/saleor/saleor/blob/b17f360e4e52d12be1f9a3828ff0211adf7001d1/saleor/product/search.py#L63-L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant