Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust CheckoutDiscountedObjectWhere filters #14943

Closed
IKarbowiak opened this issue Dec 7, 2023 · 0 comments
Closed

Adjust CheckoutDiscountedObjectWhere filters #14943

IKarbowiak opened this issue Dec 7, 2023 · 0 comments
Assignees
@IKarbowiak
Labels
checkout feature request New features you would like to see in Saleor promotions

Comments

@IKarbowiak
Copy link
Member

IKarbowiak commented Dec 7, 2023 •
edited
Loading

Allow filtering checkout by subtotal and total price.

  • Finish total_price filtering.
  • Add subtotal_price filtering similar to total_price filtering.
  • Add test for create_or_update_discount_objects_from_promotion_for_checkout with the scenario when one promotion rule has a subtotal based predicate, and the second one has a total base predicate.

Part of #14587
@IKarbowiak IKarbowiak self-assigned this Dec 7, 2023
@timuric timuric added checkout feature request New features you would like to see in Saleor labels Dec 13, 2023
@IKarbowiak IKarbowiak changed the title Add checkout where filters Adjust CheckoutDiscountedObjectWhere filters Jan 5, 2024
This was referenced Jan 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IKarbowiak IKarbowiak

Labels
checkout feature request New features you would like to see in Saleor promotions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timuric @IKarbowiak