Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfillment shipping_date field is not used #2433

Closed
3 tasks
maarcingebala opened this issue Jul 19, 2018 · 3 comments · Fixed by #4984
Closed
3 tasks

Fulfillment shipping_date field is not used #2433

maarcingebala opened this issue Jul 19, 2018 · 3 comments · Fixed by #4984
Assignees

Comments

@maarcingebala
Copy link
Member

In the Fulfillment model we have shipping_date which isn't used anywhere in the UI nor in the code. I assume that the idea behind this field is to give the user the expected date of shipping. To handle that field we should do the following:

  • include this field in FulfillmentForm and FulfillmentTrackingNumberForm,
  • include it in fulfillment emails sent to the customer,
  • show it in the customer's order view in the storefront.
@akjanik akjanik self-assigned this Jul 19, 2018
@akjanik
Copy link
Contributor

akjanik commented Jul 19, 2018

This field is being used, it sets itself as the moment of creation of the fulfillment. We could consider to display it in dashboard UI or move this to dashboard 2.0.

@stale
Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 1, 2019
@maarcingebala
Copy link
Member Author

Since the shipping_date serves only the purpose of keeping the creation date of the instance, I would rewrite it to make it more consistent with the codebase to:

created = models.DateTimeField(auto_now_add=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants