Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopDomainUpdate should return errors when empty strings given #3090

Closed
dominik-zeglen opened this issue Oct 10, 2018 · 1 comment
Closed
Labels
bug graphql Issues related to the GraphQL API

Comments

@dominik-zeglen
Copy link
Contributor

What I'm trying to achieve

To unset the shop's domain.

Steps to reproduce the problem

  1. Execute the following query:
mutation {
  shopDomainUpdate(input: {domain: ""}) {
    errors {
      field
      message
    }
    shop {
      domain {
        host
        url
      }
    }
  }
}
  1. Notice that while domain was not updated, API returned no errors.

What I expected to happen

To get an error.

@dominik-zeglen dominik-zeglen added the graphql Issues related to the GraphQL API label Oct 10, 2018
@Pacu2 Pacu2 added the bug label Oct 10, 2018
@maarcingebala
Copy link
Member

An empty domain would break some functionalities of Saleor such as generating URLs in emails. We rather shouldn't allow setting an empty value there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug graphql Issues related to the GraphQL API
Projects
None yet
Development

No branches or pull requests

3 participants