Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thumbnail generation from migrations #3494

Closed
maarcingebala opened this issue Dec 19, 2018 · 1 comment · Fixed by #4983
Closed

Remove thumbnail generation from migrations #3494

maarcingebala opened this issue Dec 19, 2018 · 1 comment · Fixed by #4983
Assignees

Comments

@maarcingebala
Copy link
Member

One of the past PRs introduced thumbnail generation in the migration file. We had a discussion with @artursmet that this may cause performance issues if people have a large number of images in their projects. Instead, thumbnail generation should be triggered manually (e.g. with python manage.py create_thumbnails.)

Since we rather cannot remove the migration file as there are others that depend on it, I'd recommend simply removing the image generation code:

https://github.com/mirumee/saleor/blob/master/saleor/product/migrations/0077_generate_versatile_background_images.py

@stale
Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants