Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Scalar #4640

Open
fowczarek opened this issue Aug 13, 2019 · 5 comments
Open

URL Scalar #4640

fowczarek opened this issue Aug 13, 2019 · 5 comments
Labels
graphql Issues related to the GraphQL API

Comments

@fowczarek
Copy link
Member

We need to refactor URL in API by introducing URL Scalar because in some part of GraphQL Api we using string type to handle URL. Mutation like SetPassword or DeleteAccount have URL as argument.
@fowczarek fowczarek added the graphql Issues related to the GraphQL API label Aug 13, 2019
@stale
Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 1, 2019
@stale stale bot removed the stale label Nov 5, 2019
@stale stale bot removed the stale label Nov 5, 2019
@maarcingebala maarcingebala added stale and removed stale labels Nov 5, 2019
@stale
Copy link

stale bot commented Jan 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 4, 2020
@fowczarek fowczarek removed the stale label Jan 7, 2020
@stale
Copy link

stale bot commented Mar 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 7, 2020
@fowczarek fowczarek removed the stale label Mar 9, 2020
@peelar peelar removed the backlog label Aug 17, 2022
@aniav
Copy link
Contributor

aniav commented Sep 28, 2023 •
edited

Is this still valid? What's the downside of using a string for URLs in GraphQL?

@fowczarek
Copy link
Member Author

The idea behind this scalar was to have unified URL validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aniav @maarcingebala @fowczarek @peelar