Meeting created without a subject

[simjker]

Issue

It is possible to create a meeting without a subject despite this being a mandatory field.

Expected Behavior

When you try to save a meeting without a subject then the invalid subject field is highlighted and the meeting is not saved. The user remains on the meeting Create form.

Actual Behavior

When you try to save a meeting without a subject then the invalid subject field is highlighted and a standard Chrome unload pop-up is displayed asking if you wish to leave the site. If you click Leave in the pop-up then a meeting is created with a blank subject. The meeting Details view form is displayed

Possible Fix

Change the custom save button type on the create meeting form from 'submit' to 'button'.
Edit modules/meetings/metadata/editviewdefs.php line 60. Change it from:

'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id ="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.meetings.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if} formSubmitCheck();"type="submit" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',

to

'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id ="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.meetings.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if} formSubmitCheck();"type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',

Steps to Reproduce

SuiteCRM Demo

1. On the menu select Activities->Meetings
2. Click the Schedule Meeting button
3. Click the Save button on the Create meeting screen
4. In the browser pop-up click the Leave button
5. Meeting is created and Meeting detail view shown for meeting with no subject

Instructions relate to Suite P theme and Chrome, but same behaviour is exhibited in all themes and Firefox

Context

Testing SuiteCRM

Your Environment

• SuiteCRM Version used: 7.7.6
• Themes: Suite7, Suite R, Suite P
• Browser name and version: Chrome Version 54.0.2840.71 m; Firefox 49.0.2
• Environment name and version: SuiteCRM demo site
• Operating System and version: SuiteCRM demo site