Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enable SAML Authentication" checkbox backs to be not selected when re-open "Password Management" window #4247

Closed
sandrotassa opened this issue Sep 12, 2017 · 0 comments
Labels
Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase

Comments

@sandrotassa
Copy link

sandrotassa commented Sep 12, 2017

Issue

After you have selected the "Enable SAML Authentication" checkbox and saved the configuration, if you re-open the "Password Management" section, the "Enable SAML Authentication" checkbox back to be not selected (note that the SAML authentication is yet active until you don't save the configuration)

Expected Behavior

"Enable SAML Authentication" checkbox should remain selected.

Actual Behavior

"Enable SAML Authentication" checkbox back to be not selected.

Possible Fix

The SAML Authentication enabled configuration is stored in the following parameter
$sugar_config['authenticationClass'] = 'SAML2Authenticate';
you can find it in the config_override.php in the root of the suitecrm installation

In the template view of "Password Management" an if condition is performed on "SAMLAuthenticate" value (vs SAML2Authenticate)

see file "modules/Administration/PasswordManager.tpl" row:435
{if !empty($config.authenticationClass) && $config.authenticationClass == 'SAMLAuthenticate'}

Changing the template if condition fix the specific issue but there are many piece of code where if condition uses the string "SAMLAuthenticate" instead of "SAML2Authenticate".

Steps to Reproduce

  1. go to admin-> "Password Management"
  2. "Enable SAML Authentication" checkbox
  3. save the configuration
  4. go to admin-> "Password Management" again

Context

Your Environment

  • SuiteCRM Version used: 7.8.6
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): any
  • Environment name and version (e.g. MySQL, PHP 7): PHP7.1.9, MariaDB 5.5.52
  • Operating System and version (e.g Ubuntu 16.04): Centos 7.2.1511
@sandrotassa sandrotassa changed the title the "Enable SAML Authentication" checkbox is unselected when re-open "Password Management" window the "Enable SAML Authentication" checkbox backs to be not selected when re-open "Password Management" window Sep 12, 2017
@sandrotassa sandrotassa changed the title the "Enable SAML Authentication" checkbox backs to be not selected when re-open "Password Management" window "Enable SAML Authentication" checkbox backs to be not selected when re-open "Password Management" window Sep 12, 2017
@Dillon-Brown Dillon-Brown added Type:Bug Bugs within the core SuiteCRM codebase Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds labels Sep 25, 2017
@Dillon-Brown Dillon-Brown added Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Resolved: Next Release labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

3 participants