Campaigns/ProcessBouncedEmails does not mark invalid mails as invalid

[gody01]

Campaign Bounce Mail processing does not mark bounced emails as invalid.

Issue

It seems that criteria for marikng bounced email as invalid is

//do we have the phrase permanent error in the email body.
if (preg_match('/permanent[ ]*error/',$email_description))

But nobody users such string any more.

It would be better, to check for "550 5.1.1" code in raw email as it seems somehow de-facto standard for Unknown user message.

Expected Behavior

If email bounce with User unknown message, SuiteCRM should mark such Email as invalid.

Actual Behavior

Practically no bounced Emails are marked as invalid

Possible Fix

change criteria or add check for "550 5.1.1" to the if statement.

Steps to Reproduce

1. Send email campaigns with not existent email addresses
2. Wait for bounce messages
3. Check, if bounced emails are marked invalid

Context

Automatic bounced mail handling was very useful, since emails were automatically marked as invalid in case mail bounced.

Your Environment

• SuiteCRM Version used: 7.10.4
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): All
• Environment name and version (e.g. MySQL, PHP 7): All
• Operating System and version (e.g Ubuntu 16.04): Linux - CentOS, OpenSuSE, ...

[pgorod]

@amariussi since you do a lot of Campaigns (I believe) can you try this change to see if it works well?

I mean, check for 550 5.1.1 instead of what is currently there.

[amariussi]

@pgorod Just noticed this. Although lately I have been using a different method to send campaigns (unfortunately SuiteCRM is far from being fit for Campaigns at the moment) I will try it out and post my comments, if any.

Just a few quick comments on this subject:
. there should be several criteria to detect bounced messages
. admins should be allowed to select (or add) the criterias used (maybe in config_override,php or, even better, through a dedicated section of the Admin page)
. also the actions should be optional and, possibly multiple actions should be allowed (why would we, developers, impose the action to be taken, like mark email as invalid or delete it or put it in a blacklist to be verified: this should be decided autonomously by the single SuiteCRM users/administrators!!!)

[lazka]

I've created a fix for this: #6505

[samus-aran]

This is now a duplicate and this issue supersedes this.
#6504
If able @gody01 Can you assess the proposed pull request that would be great to progress it!