Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow runs but it's actions aren't executed #6718

Closed
goldmanmichelle opened this issue Jan 4, 2019 · 3 comments
Closed

Workflow runs but it's actions aren't executed #6718

goldmanmichelle opened this issue Jan 4, 2019 · 3 comments
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author

Comments

@goldmanmichelle
Copy link

Issue

I have created many workflows (on custom and existing modules, like quotes and invoices) that run independent of the scheduler and they have been working but have found that periodically some of my workflows will suddenly stop working for no apparent reason. I have checked the workflows' process audits which show that the workflow does run.

job_workflow
estimate_workflow

Expected Behavior

For 2 of my workflows, I have a condition for when the quote (renamed estimate) name changes the invoice (renamed job) name will update using the estimate name and vice versa.

Actual Behavior

When changing the name of the quote , the invoice name no longer updates and vice versa.

SuiteCRM.log

Fri Jan 4 14:23:13 2019 [727076][1][FATAL] Query Failed: SELECT reminders.* , jt0.user_name modified_by_name , jt0.created_by modified_by_name_owner , N'Users' modified_by_name_mod , jt1.user_name created_by_name , jt1.created_by created_by_name_owner , N'Users' created_by_name_mod , jt2.user_name assigned_user_name , jt2.created_by assigned_user_name_owner , N'Users' assigned_user_name_mod FROM reminders LEFT JOIN users jt0 ON reminders.modified_user_id=jt0.id AND jt0.deleted=0

AND jt0.deleted=0 LEFT JOIN users jt1 ON reminders.created_by=jt1.id AND jt1.deleted=0

AND jt1.deleted=0 LEFT JOIN users jt2 ON reminders.assigned_user_id=jt2.id AND jt2.deleted=0

AND jt2.deleted=0 where (reminders.popup = 1 AND (reminders.date_willexecute = -1 OR reminders.date_willexecute BETWEEN AND )) AND reminders.deleted=0::: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'AND'.
Fri Jan 4 14:25:21 2019 [727076][1][FATAL] Query Failed: SELECT reminders.* , jt0.user_name modified_by_name , jt0.created_by modified_by_name_owner , N'Users' modified_by_name_mod , jt1.user_name created_by_name , jt1.created_by created_by_name_owner , N'Users' created_by_name_mod , jt2.user_name assigned_user_name , jt2.created_by assigned_user_name_owner , N'Users' assigned_user_name_mod FROM reminders LEFT JOIN users jt0 ON reminders.modified_user_id=jt0.id AND jt0.deleted=0

AND jt0.deleted=0 LEFT JOIN users jt1 ON reminders.created_by=jt1.id AND jt1.deleted=0

AND jt1.deleted=0 LEFT JOIN users jt2 ON reminders.assigned_user_id=jt2.id AND jt2.deleted=0

AND jt2.deleted=0 where (reminders.popup = 1 AND (reminders.date_willexecute = -1 OR reminders.date_willexecute BETWEEN AND )) AND reminders.deleted=0::: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'AND'.
Fri Jan 4 14:25:27 2019 [727076][1][FATAL] Query Failed:DECLARE @topCount INT SET @topCount = 1 SELECT TOP (@topCount) aos_invoices.id AS id FROM aos_invoices LEFT JOIN aos_quotes_aos_invoices_c ON aos_invoices.id=aos_quotes_aos_invoices_c.aos_quotes6b83nvoices_idb AND aos_quotes_aos_invoices_c.deleted=0

LEFT JOIN aos_quotes aos_quotes_aos_invoices ON aos_quotes_aos_invoices.id=aos_quotes_aos_invoices_c.aos_quotes77d9_quotes_ida AND aos_quotes_aos_invoices.deleted=0
LEFT JOIN aos_quotes_cstm aos_quotes_aos_invoices_cstm ON aos_quotes.id = aos_quotes_aos_invoices_cstm.id_c WHERE aos_quotes_aos_invoices_cstm.estimate_type_c = N're_waterproofing' AND aos_invoices.id = N'14cb95ae-b5fe-0c28-c205-5c1aa7cecf68'::: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The multi-part identifier "aos_quotes.id" could not be bound.
Fri Jan 4 14:29:29 2019 [708880][1][FATAL] log call at: modules/Administration/index.tpl:54 - MY_FRAME is not set
Fri Jan 4 14:30:32 2019 [708880][1][FATAL] log call at: modules/Administration/index.tpl:54 - MY_FRAME is not set
Fri Jan 4 14:30:37 2019 [708880][1][FATAL] Query Failed: SELECT reminders.* , jt0.user_name modified_by_name , jt0.created_by modified_by_name_owner , N'Users' modified_by_name_mod , jt1.user_name created_by_name , jt1.created_by created_by_name_owner , N'Users' created_by_name_mod , jt2.user_name assigned_user_name , jt2.created_by assigned_user_name_owner , N'Users' assigned_user_name_mod FROM reminders LEFT JOIN users jt0 ON reminders.modified_user_id=jt0.id AND jt0.deleted=0

PHP.ini

[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:25:27 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:38 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:31:46 Europe/Dublin] PHP Notice: session_start(): ps_files_cleanup_dir: opendir(C:\Windows\temp) failed: No error (0) in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\include\MVC\SugarApplication.php on line 596
[04-Jan-2019 14:34:00 Europe/Dublin] PHP Warning: Declaration of SugarFieldTime::save(&$bean, &$inputData, &$field, &$def, $prefix = '') should be compatible with SugarFieldBase::save(&$bean, $params, $field, $properties, $prefix = '') in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\include\SugarFields\Fields\Time\SugarFieldTime.php on line 95
[04-Jan-2019 14:34:01 Europe/Dublin] PHP Warning: Declaration of SchedulersViewDetail::_getModuleTitleListParam() should be compatible with SugarView::_getModuleTitleListParam($browserTitle = false) in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Schedulers\views\view.detail.php on line 69
[04-Jan-2019 14:34:32 Europe/Dublin] PHP Warning: Declaration of SugarFieldTime::save(&$bean, &$inputData, &$field, &$def, $prefix = '') should be compatible with SugarFieldBase::save(&$bean, $params, $field, $properties, $prefix = '') in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\include\SugarFields\Fields\Time\SugarFieldTime.php on line 95
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96
[04-Jan-2019 14:39:16 Europe/Dublin] PHP Warning: A non-numeric value encountered in C:\inetpub\Dev\dev.roofdini.biscayneroofing.com\modules\Currencies\Currency.php on line 96

Possible Fix

I've cleared browser cache, run a quick repair and still workflows that stopped working will not run.
I've also tried checking and unchecking repeated runs; selecting all records and modified records; run always and only on save.

Steps to Reproduce

  1. Edit a quote's name and save the record.
  2. Edit an invoice's name and save the record.

Context

This is a customer requirement which was working and now isn't. This is just 1 example of 2 workflows that have spontaneously stopped working. I have about 6 workflows altogether that have stopped worked. Literally, a workflow will be working 1 day and the next day it fails to work and has been happening for weeks with different workflows. When "things" just stop working, it does not give a good impression of the software overall.

If workflows don't work consistently and stop working, I believe this should be a high priority as this is a huge piece of the application.

Your Environment

  • SuiteCRM Version used: 7.10.7
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome 71.0.3578.98 (64-bit)
  • Environment name and version (e.g. MySQL, PHP 7): SQL Server 2014, PHP 7.2
  • Operating System and version (e.g Ubuntu 16.04): Windows Server 2012 R2
@willrennie
Copy link
Contributor

@goldmanmichelle I've been unable to replicate your issue testing workflows, on the latest 7.10.x release. I would recommend that you check your php logs for errors and also check the job_queue table in the database to assess the result for the workflow scheduler. Even when schedulers state 'done' and 'success' they can sometimes still fail and log the failure reason in the job_queue table. You state the workflows stop working. Is this after a set period of time? How many records is the workflow running on? If you can provide more information, that would be great. Thanks.

@willrennie willrennie added the Status:Requires Updates Issues & PRs which requires input or update from the author label Apr 5, 2019
@pgorod
Copy link
Contributor

pgorod commented Apr 5, 2019

I saw a person in the Forums with a similar erratic Workflows issue and it was caused by overgrown tables in the database, namely job_queue and aow_processed.

@Dillon-Brown
Copy link
Contributor

I'm unable to replicate this issue on hotfix or latest LTS. Please let me know if this is still an issue you can replicate and we will investigate further. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

No branches or pull requests

4 participants