Error in SearchForm2.php when having a function in field definition

[Abuelodelanada]

Issue

If you have a field in vardefs.php defined like this:

        'product_selector' => array(
            'name' => 'product_selector',
            'vname' => 'LBL_GCOOP_PRODUCT_NAME',
            'type' => 'enum',
            'len' => 36,
            'options' => '',
            'massupdate' => 0,
            'source' => 'non-db',
            'required' => true,
            'function' => array(
                'name' => 'get_products',
                'include' => 'modules/gcoop_SalesOpportunity/Helper.php',
            ),
        ),

And loading a subpanel of that module a Warning appears:

Warning: call_user_func() expects parameter 1 to be a valid callback, function 'get_products' not found or invalid function name in /home/jose/trabajos/gca-suitecrm7.10x/include/SearchForm/SearchForm2.php on line 693

In the context of line 693 of include/SearchForm/SearchForm2.php you can see:

if (!empty($this->fieldDefs[$fvName]['function']['returns']) && $this->fieldDefs[$fvName]['function']['returns'] == 'html') {
    if (!empty($this->fieldDefs[$fvName]['function']['include'])) {
        require_once($this->fieldDefs[$fvName]['function']['include']);
    }
    $value = call_user_func($function_name, $this->seed, $name, $value, $this->view);
    $this->fieldDefs[$fvName]['value'] = $value;
} else {
    if (!isset($function['params']) || !is_array($function['params'])) {
        $this->fieldDefs[$fvName]['options'] = call_user_func($function_name, $this->seed, $name, $value, $this->view);
    } else {
        $this->fieldDefs[$fvName]['options'] = call_user_func_array($function_name, $function['params']);
    }
}

The problem is that the code execute a require_once only in the IF structure and not in the ELSE structure.

Expected Behavior

To require the function defined in vardefs.php

Actual Behavior

In some cases do not require the function

Possible Fix

Execute the require_once before the if..else structure or in both if and else.

Steps to Reproduce

1. Define a function in a field in vardefs.php (Module A)
2. Load a DetailView of Module B that hava a subpanel of Module A
3. Check php log.

Your Environment

• SuiteCRM Version used: 7.10.x