Module Builder doesn't regenerate class

[FR-JS]

Issue

When using the Module Builder, once a package has been published changing settings such as 'importable' doesn't get reflected in the published zip file.
The MBPackage::build function has the parameter 'clean' which is false by default and cannot find anywhere which either sets this to true or purges the build directory before publishing.

Expected Behavior

I would expect the build directory to be emptied before building the module.

Actual Behavior

Build directory is left with contents of previous build and existing files are left untouched.

Possible Fix

Remove the build directory at the start of MBPackage::build()

Steps to Reproduce

1. Use the Module Builder to build a new module and set 'importable' to false
2. Publish the module
3. Use the Module Builder to change set 'importable' to true on the recently built module
4. Publish the module

Context

Changes to modules cannot be done by non developers as changes require access to the filesystem to clean out existing builds.

Your Environment

• SuiteCRM Version used: 7.11.6
• Environment name and version (e.g. MySQL, PHP 7): PHP 7.3
• Operating System and version (e.g Ubuntu 16.04): Debian 10

[ebogaard]

The main issue behind this is still valid in 7.11.22.
The "custom/modulebuilder/builds/" isn't cleaned before Publishing or Exporting, so old files are still included in the resulting .zip.

The work around for now, is to manually remove the "custom/modulebuilder/builds/" folder before Publishing or Exporting.

[SuiteBot]

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/quiero-importar-datos-al-suite-crm/91619/2

[chris001]

This should be easily fixed by having the code remove custom/modulebuilder/builds/* before both Export and Publish.