Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include/timezone/timezones.php #7594

Closed
connorshea opened this issue Jul 18, 2019 · 0 comments
Closed

Remove include/timezone/timezones.php #7594

connorshea opened this issue Jul 18, 2019 · 0 comments
Labels
Area: Clean Up Issues & PRs related to all things regarding to technical debt and log files Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase

Comments

@connorshea
Copy link
Contributor

Issue

This file presumably doesn't need to exist anymore: https://github.com/salesagility/SuiteCRM/blob/master/include/timezone/timezones.php

Expected Behavior

This file wouldn't exist.

Actual Behavior

The file exists 'for compatibility reasons'.

Possible Fix

Remove the file and its directory include/timezone/.

Context

The file hasn't been changed (except minor formatting changes) since the initial commit of SuiteCRM, so it's 6 years old – if not older.

https://github.com/salesagility/SuiteCRM/blob/8e51b0e900d7e8cf39529c39ab2976583c638e69/include/timezone/timezones.php
@Dillon-Brown Dillon-Brown added Type:Bug Bugs within the core SuiteCRM codebase Area: Clean Up Issues & PRs related to all things regarding to technical debt and log files Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds labels Jul 19, 2019
@connorshea connorshea mentioned this issue Jul 19, 2019
Merged
6 tasks
@Dillon-Brown Dillon-Brown added Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Resolved: Next Release labels Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Clean Up Issues & PRs related to all things regarding to technical debt and log files Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@connorshea @Dillon-Brown @Mac-Rae