Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate instance of touch-punch.min.js #7715

Open
connorshea opened this issue Aug 13, 2019 · 1 comment
Open

Remove duplicate instance of touch-punch.min.js #7715

connorshea opened this issue Aug 13, 2019 · 1 comment
Labels
Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement

Comments

@connorshea
Copy link
Contributor

We have two identical minified versions of this file:

It looks like the latter file was introduced in 7fbc159, which would suggest to me that this one should be removed in favor of the other.

Also, it should probably be moved to the jssource directory in non-minified form.

Based on searching for touch-punch, it looks like the file in include/javascript/jquery/ is used by JSGroupings.php and the other file is used by modules/Spots/tpl/ShowSpots.tpl and modules/Spots/Dashlets/SpotsDashlet/SpotsDashlet.tpl.

@connorshea
Copy link
Contributor Author

I would think we can remove the explicit script tags for touch-punch in those two template files since the grouped file should automatically be included on the pages 🤔

@cameronblaikie cameronblaikie added the Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement
Projects
None yet
Development

No branches or pull requests

2 participants