Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in User profile with French translation (quote) #7917

Closed
QuickCRM opened this issue Sep 24, 2019 · 4 comments
Closed

Errors in User profile with French translation (quote) #7917

QuickCRM opened this issue Sep 24, 2019 · 4 comments
Labels
Area: Emails:Config Issues & PRs related to email configuration Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase

Comments

@QuickCRM
Copy link
Contributor

browser console shows:

  • SyntaxError: Unexpected identifier 'utilisateur'
  • ReferenceError: Can't find variable: tinyConfig
    Then, you can't edit Emails parameters

Issue

Expected Behavior

Actual Behavior

Possible Fix

See modules/Emails/EmailUI.php
change the way quotes are escaped:
$v = str_replace("'", "'",$v);
=>
$v = str_replace("'", "'",str_replace("\'", "'", $v));

Steps to Reproduce

  1. Install french translation
  2. log in french
  3. go to user profile
  4. look at the browser console
    5 click on Emails parameters

Context

Your Environment

  • SuiteCRM Version used: 7.10.20
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): any
  • Environment name and version (e.g. MySQL, PHP 7): any
  • Operating System and version (e.g Ubuntu 16.04): any
@QuickCRM
Copy link
Contributor Author

The PHP possible fix was not saved correctly by Github.
We will submit a PR

@Dillon-Brown
Copy link
Contributor

Hi @QuickCRM, thanks for the PR! just to note for the future, if you want to post code in a GitHub issue you can encapsulate it with three backticks ``` like this:

<?php
echo 'Hello World!';

and it should keep it intact.

@Dillon-Brown Dillon-Brown added Type:Bug Bugs within the core SuiteCRM codebase Area: Emails:Config Issues & PRs related to email configuration Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds labels Sep 24, 2019
@pgorod
Copy link
Contributor

pgorod commented Sep 24, 2019

It's gets even better if you add a language name, like this:
```php
or
```bash

<?php
function helloWorld() {
   echo 'Hello World!';
}

you get syntax highlighting.

@holdusback
Copy link

holdusback commented Nov 5, 2019

As a french dev & user so much error like this, for example in /index.php?module=Configurator&action=EditView

In the console "Uncaught SyntaxError: missing ) after argument list"

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails:Config Issues & PRs related to email configuration Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

6 participants