API V8 doesn't work with id's that are no UUID

[DavyVanElst]

Issue

I have created some records (Accounts and Contacts) that are imported from an external system and I've used the id's from the external system as the id in SuiteCRM as well. This is possible by setting the 'strict_id_validation' => false, in the config.php file. However this doesn't work with the V8 API that has a hardcoded requirement on the format of the id, rejecting calls made to id's that are not in the UUID format.

Expected Behavior

The Api V8 should accept all the id formats that are accepted by the UI and as such also use the value of the strict_id_validation' flag.

Actual Behavior

The Api V8 uses its own hardcoded regular expression as specified in the file Api/V8/Param/Options/Id.php, which only allows UUID's.

Possible Fix

Change the id.php to either (best case) use the exact same validation as the UI for id's or (not optimal case) use a different regular expression when the strict_id_validation flag is not set.

Steps to Reproduce

1.Set the 'strict_id_validation' => false, in the config.php.
2.Import (create) a Contact with an id that is not a UUID.
3.Try to get the Contact based on the id.

Context

I'm using the api to connect to other systems, however I have located the regular expression and corrected it to work for me, however this solution is not upgrade proof.

Your Environment

• SuiteCRM Version used:
  Version 7.11.13
  Sugar Version 6.5.25 (Build 344)

[pgorod]

SuiteCRM should not restrict its ID's to UUIDs. Breaks backwards compatibility, causes unnecessary pain in integrations and migrations. I say this loud and clear, every chance I get, since the sad day where that "validation" was introduced... sigh...

[SuiteBot]

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/relationships-between-modules/91830/4