Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade process will update some files but these files also exist in custom/ folder. Please review the changes before continuing #9017

Closed
Jawn78 opened this issue Jan 20, 2021 · 8 comments
Labels
Area: Upgrading Issues & PRs related to all things regarding upgrading & UpgradeWizard Status:Requires Updates Issues & PRs which requires input or update from the author Status: Stale For issues & PRs that have had no activity Type:Discussion Issues & PRs related to ongoing discussions

Comments

@Jawn78
Copy link

Jawn78 commented Jan 20, 2021

The expected behavior is for the Upgrade wizard to install the package and maintain the customizations made through studio. I have made some edits through Studio to add fields and custom views, nothing all that complex or outside of studio.

I am upgrading from 7.11.15 to 7.11.18. When Uploading the package I get the following alert

Proposed Solution: : I can go through and delete the individual files (or perhaps install the originals, then update, then go back and make the customizations, to hopefully get things working without issues. But there are a number of concerns/problems here.

  • Will uninstalling these customizations break the environment (stopping the ability to use upgrade wizard)
  • The time it will take to make these changes manually, and room for error lining up with database, etc
  • The hindrance to updating in the future.
  • No option to proceed and overwrite files using the wizard (package is removed when alerts show)

At this point I don’t have the time to do this manually, is there hope to a better solution?

@mattlorimer
Copy link
Member

Thank you for reporting this issue, there should be no issue upgrading specific to have standard and upgrade safe customisations, so this seems like a overly verbose and unhelpful message. Can you confirm it is not letting you upgrade or this message is killing the upgrade process.

If so without looking further at this issue, I would suggest doing a silent upgrade via the terminal if possible - https://docs.suitecrm.com/admin/installation-guide/upgrading/

Of course always take full backup before doing any upgrade.

@pgorod
Copy link
Contributor

pgorod commented Jan 21, 2021

@Jawn78
Copy link
Author

Jawn78 commented Jan 21, 2021

@pgorod I understand what you are saying in the original thread, it just seems very counter intuitive to the purpose of the customization / studio features. It also has a great margin of error. Given that I backed it up (as recommended), you would think the wizard wouldn't stop but overwrite those files. Then I could at least push the changes comparing from the backup and not also have to manually update. I would hope to have the option to at least proceed after the warning. I can somewhat understand avoiding trying to carry over customizations, especially for those doing changes outside of the studio.

I am going to try doing what @mattlorimer suggested, and see if I can proceed as I am suggesting above. I haven't run into this issue with any of the other upgrades. So, It just caught me off-guard. I was considering hiring someone to build out some decent customizations / workflows to match my business case (using as an applicant tracking system for recruiting). This is making me reconsider that. I suppose I could track the changes from here, write a script to remove, then run the update then add them into the files.

@pgorod
Copy link
Contributor

pgorod commented Jan 21, 2021

Normally when this message appears, the wizard is not interrupted. You should be able to continue with the upgrade.

So if you're getting interrupted, that is possibly a bug, and that's why this is looking harder for you than it does for me...

@johnM2401 johnM2401 added Area: Upgrading Issues & PRs related to all things regarding upgrading & UpgradeWizard Status:Requires Updates Issues & PRs which requires input or update from the author Type:Discussion Issues & PRs related to ongoing discussions labels Jan 22, 2021
@Jawn78
Copy link
Author

Jawn78 commented Jan 26, 2021

@pgorod trying to run a manual upgrade caused a database error. Upgrade log says to refer to suitecrm.log but there is nothing in the log about it.

Looks like I need to do a clean install and do my best to transfer everything over

@pgorod
Copy link
Contributor

pgorod commented Jan 26, 2021

HAve you been checking your PHP error log? The one defined in your php.ini, error_log and error_reporting directives.

@serhiisamko091184 serhiisamko091184 added the Status: Stale For issues & PRs that have had no activity label Mar 15, 2024
@serhiisamko091184
Copy link
Contributor

Hello, @Jawn78

This issue has been marked as stale because there has been no recent activity. It will be closed if no further activity occurs.
Thanks for your contributions.

Regards,
Serhii

@serhiisamko091184
Copy link
Contributor

Hey @Jawn78

Closing this issue due to inactivity.
Thank you.

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Upgrading Issues & PRs related to all things regarding upgrading & UpgradeWizard Status:Requires Updates Issues & PRs which requires input or update from the author Status: Stale For issues & PRs that have had no activity Type:Discussion Issues & PRs related to ongoing discussions
Projects
None yet
Development

No branches or pull requests

5 participants