Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Call .travis.deploy.sh w/bash and use curly braces #774

Merged
merged 2 commits into from Jun 21, 2018

Conversation

justinharringa
Copy link
Contributor

sh in Travis seems to work a little differently than on CentOS and switching to bash seems to bring consistency and more support back (as evidenced by experimentation done in a simple travis-source project I put together to test this)

@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #774 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #774      +/-   ##
=============================================
+ Coverage      39.03%   39.05%   +0.01%     
- Complexity      1984     1985       +1     
=============================================
  Files            294      294              
  Lines          17851    17851              
  Branches        2510     2510              
=============================================
+ Hits            6969     6972       +3     
+ Misses          9940     9938       -2     
+ Partials         942      941       -1
Impacted Files Coverage Δ Complexity Δ
...va/com/salesforce/dva/argus/system/SystemMain.java 87.17% <0%> (+2.56%) 17% <0%> (ø) ⬇️
...m/salesforce/dva/argus/service/DefaultService.java 81.81% <0%> (+9.09%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4557a...79c595a. Read the comment docs.

@dilipdevaraj-sfdc dilipdevaraj-sfdc merged commit 4036913 into develop Jun 21, 2018
@justinharringa justinharringa deleted the call-with-bash branch June 28, 2018 16:00
@justinharringa
Copy link
Contributor Author

@dilipdevaraj-sfdc are you still looking to get this merged into master?

@dilipdevaraj-sfdc
Copy link
Contributor

The process followed is - will be merged to master after the most up to date release deployment is qualified.

@justinharringa
Copy link
Contributor Author

justinharringa commented Jun 28, 2018 via email

@dilipdevaraj-sfdc
Copy link
Contributor

If code is already part of 2.15 branch it will be deployed to production. Once this build is qualified the branch will be merged to master at the last stage (this is so that master is always a working branch of latest branch)
cc @sundeepsf

@sundeepsf
Copy link
Contributor

yes, this will go into production next week

@justinharringa
Copy link
Contributor Author

justinharringa commented Jun 28, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants