Call .travis.deploy.sh w/bash and use curly braces #774
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #774 +/- ##
=============================================
+ Coverage 39.03% 39.05% +0.01%
- Complexity 1984 1985 +1
=============================================
Files 294 294
Lines 17851 17851
Branches 2510 2510
=============================================
+ Hits 6969 6972 +3
+ Misses 9940 9938 -2
+ Partials 942 941 -1
Continue to review full report at Codecov.
|
@dilipdevaraj-sfdc are you still looking to get this merged into master? |
The process followed is - will be merged to master after the most up to date release deployment is qualified. |
I see so I guess this won't make your 2.15 release or you're pushing that
release back?
…On Thu, Jun 28, 2018 at 9:05 AM dilipdevaraj-sfdc ***@***.***> wrote:
The process followed is - will be merged to master after the most up to
date release deployment is qualified.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#774 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA_oziI_JHrxxxTeCvM7ONz41iwZe4w5ks5uBP7AgaJpZM4Uykgv>
.
|
If code is already part of 2.15 branch it will be deployed to production. Once this build is qualified the branch will be merged to master at the last stage (this is so that master is always a working branch of latest branch) |
yes, this will go into production next week |
Cool. Thanks for the background 😄
…On Thu, Jun 28, 2018 at 10:30 AM Sundeep Tiyyagura ***@***.***> wrote:
yes, this will go into production next week
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#774 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA_ozs7r0RLqDxRmFAD2NHzQYGMDcv5Aks5uBRKYgaJpZM4Uykgv>
.
|
sh
in Travis seems to work a little differently than on CentOS and switching tobash
seems to bring consistency and more support back (as evidenced by experimentation done in a simple travis-source project I put together to test this)