Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator does not check for number of label classes and number of rows for each split #161

Open
tovbinm opened this issue Oct 22, 2018 · 0 comments
Open

Validator does not check for number of label classes and number of rows for each split #161

tovbinm opened this issue Oct 22, 2018 · 0 comments
Assignees
@Jauntbox
Labels
bug

Comments

@tovbinm
Copy link
Collaborator

tovbinm commented Oct 22, 2018 •
edited

Describe the bug
None of the implementations of OpValidator.createTrainValidationSplits does not check that:

  1. number of label classes is at least 2
  2. splits are not empty

To Reproduce
Run OpCrossValidation or OpTrainValidationSplit of data with a single row.

Expected behavior
Validate that number of label classes if at least 2 and splits are not empty. Throw a clean and informative error in each of the cases.
@tovbinm tovbinm added the bug label Oct 22, 2018
@tovbinm tovbinm changed the title Validator does not check for number of rows for each label Validator does not check for number of label classes and number of rows for each split Oct 23, 2018
@tovbinm tovbinm mentioned this issue Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jauntbox Jauntbox

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tovbinm @Jauntbox