Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commenting out pandas writing to Excel #99

Merged
merged 1 commit into from Jan 26, 2022
Merged

commenting out pandas writing to Excel #99

merged 1 commit into from Jan 26, 2022

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Jan 19, 2022

What does this PR do?

essentially reverting #37 to fix #88

What gif best describes this PR or how it makes you feel?

panda

Completion checklist

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @PatMyron to sign the Salesforce.com Contributor License Agreement.

@kmcquade
Copy link
Collaborator

@PatMyron is there a reason for this?

@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 19, 2022

@kmcquade fixes #88 (cron updating data again); currently fails with ModuleNotFoundError: No module named 'pandas'

spent hours trying to fix .xlsx writing in Github actions instead, but .csv seems sufficient if .xlsx causes that much trouble in Github actions

@kmcquade
Copy link
Collaborator

kmcquade commented Jan 19, 2022

It won't return the module not found error if you run pipenv install --dev first :)

@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 19, 2022

That works locally, but it's been running into No module named 'pandas' even after pipenv install --dev in Github actions:
https://github.com/salesforce/aws-allowlister/runs/4823542865?check_suite_focus=true

@kmcquade kmcquade merged commit 69ac75c into salesforce:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compliance Data update automation is failing
2 participants