Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in sparknotes/get_summaries.py #7

Closed
dojoteef opened this issue Jun 3, 2021 · 1 comment
Closed

Bugs in sparknotes/get_summaries.py #7

dojoteef opened this issue Jun 3, 2021 · 1 comment

Comments

@dojoteef
Copy link

dojoteef commented Jun 3, 2021

There are a couple of bugs in sparknotes/get_summaries.py:

  1. Line 82 can lead to a crash if the span cannot be found. It should probably get moved into the try/except block above on line 76.
  2. On line 128, you should probably continue if there are no section paragraphs, i.e. no summary.
@jigsaw2212
Copy link
Contributor

During the testing of the script Line 82 doesn't crash for any of the web archive links. However, since the web archive servers are not as reliable, I've added some extra error handling for this line too. Suggestion incorporated for line 128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants