Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Expand Button text is hard-coded and cannot be changed by consumer #2019

Open
interactivellama opened this issue Jun 7, 2019 · 1 comment

Comments

@interactivellama
Copy link
Contributor

"Expand Tree Branch" text is not able to be changed by library consumers.

I propose updating Tree props to:

	assistiveText: PropTypes.shape({
		label: PropTypes.string,
		expandBranchLabel: PropTypes.string,
	}),

expandBranchLabel default value is "Expand Tree Branch".

https://github.com/salesforce/design-system-react/blob/master/components/tree/index.jsx#L28

@interactivellama
Copy link
Contributor Author

@AnutaK This bug fix is very close to #2007. A few of the same lines of code get touched, so I thought I'd group it. This is mostly making the line https://github.com/salesforce/design-system-react/blob/master/components/tree/private/render-branch.jsx#L307 a variable and getting that variable from the top level tree/index.jsx props.

Is what I am asking for clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants