Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isNodeFromTemplate hacks to expose elements without an ownerKey #1252

Open
caridy opened this issue May 21, 2019 · 2 comments
Open

remove isNodeFromTemplate hacks to expose elements without an ownerKey #1252

caridy opened this issue May 21, 2019 · 2 comments
Labels
BUG P1 bug need consensus issues marked as such need some discussion Synthetic Shadow Synthetic shadow DOM polyfill

Comments

@caridy
Copy link
Contributor

caridy commented May 21, 2019

Description

The method isNodeFromTemplate is confusing on itself, its semantics are really about whether a node is inside a shadow or not, maybe we should rename it to isNodeShadowed or something similar.

There is one use-case today that is forcing us to break those semantics for a very edge case:

The Problem

  • when a node is inserted manually inside an element from template, and that element does not have the lwc:dom="manual" flag specified, the node is considered as not part of the shadowRoot when running in synthetic mode. This is considered a feature for flexipages inserting aura elements inside the flexipage, while those aura elements are accessible via a global document query.

This is plain wrong, and we should fix it, but first we need to investigate how to help those folks that are using this as a feature.

@caridy caridy added bug need consensus issues marked as such need some discussion labels May 21, 2019
@caridy
Copy link
Contributor Author

caridy commented May 21, 2019

@adheip-sfdc
Copy link

I'll have to defer to @diervo on this since it was his recommendation. I can definitely help with any changes that need to be made in flexipages, as long as we can find an alternate solution that won't regress customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG P1 bug need consensus issues marked as such need some discussion Synthetic Shadow Synthetic shadow DOM polyfill
Projects
None yet
Development

No branches or pull requests

3 participants