Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(synthetic-shadow): cleaning up tests #1334

Merged
merged 6 commits into from Jun 3, 2019
Merged

fix(synthetic-shadow): cleaning up tests #1334

merged 6 commits into from Jun 3, 2019

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jun 3, 2019

Details

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

@caridy caridy changed the title Caridy/test cleanup for separation fix(synthetic-shadow): cleaning up tests Jun 3, 2019
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 5e2678c | Target commit: 64fc811

lwc-engine-benchmark

table-append-1k metric base(5e2678c) target(64fc811) trend
benchmark-table/append/1k duration 140.10 (±3.60 ms) 144.45 (±3.60 ms) +4.3ms (3.1%) 👎
table-clear-1k metric base(5e2678c) target(64fc811) trend
benchmark-table/clear/1k duration 10.50 (±0.90 ms) 10.45 (±0.70 ms) -0.1ms (0.5%) 👌
table-create-10k metric base(5e2678c) target(64fc811) trend
benchmark-table/create/10k duration 840.30 (±6.20 ms) 855.50 (±6.10 ms) +15.2ms (1.8%) 👎
table-create-1k metric base(5e2678c) target(64fc811) trend
benchmark-table/create/1k duration 106.50 (±2.30 ms) 109.30 (±3.40 ms) +2.8ms (2.6%) 👎
table-update-10th-1k metric base(5e2678c) target(64fc811) trend
benchmark-table/update-10th/1k duration 66.75 (±1.75 ms) 77.80 (±2.80 ms) +11.1ms (16.6%) 👎
tablecmp-append-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-component/append/1k duration 221.85 (±9.40 ms) 225.75 (±9.65 ms) +3.9ms (1.8%) 👌
tablecmp-clear-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-component/clear/1k duration 7.20 (±1.25 ms) 7.00 (±1.25 ms) -0.2ms (2.8%) 👌
tablecmp-create-10k metric base(5e2678c) target(64fc811) trend
benchmark-table-component/create/10k duration 1625.00 (±8.65 ms) 1625.60 (±12.45 ms) +0.6ms (0.0%) 👌
tablecmp-create-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-component/create/1k duration 185.60 (±5.30 ms) 186.15 (±4.45 ms) +0.5ms (0.3%) 👌
tablecmp-update-10th-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-component/update-10th/1k duration 66.85 (±5.10 ms) 67.80 (±5.45 ms) +1.0ms (1.4%) 👌
wc-append-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-wc/append/1k duration 252.20 (±7.10 ms) 257.10 (±8.00 ms) +4.9ms (1.9%) 👌
wc-clear-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-wc/clear/1k duration 11.00 (±2.00 ms) 12.00 (±1.80 ms) +1.0ms (9.1%) 👌
wc-create-10k metric base(5e2678c) target(64fc811) trend
benchmark-table-wc/create/10k duration 1928.95 (±11.90 ms) 1984.50 (±13.80 ms) +55.5ms (2.9%) 👎
wc-create-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-wc/create/1k duration 237.15 (±4.65 ms) 239.45 (±4.10 ms) +2.3ms (1.0%) 👌
wc-update-10th-1k metric base(5e2678c) target(64fc811) trend
benchmark-table-wc/update-10th/1k duration 64.25 (±4.60 ms) 67.50 (±4.50 ms) +3.3ms (5.1%) 👎

caridy and others added 4 commits June 3, 2019 12:12
@caridy @ekashida
Update packages/integration-karma/test/polyfills/shadow-root/index.sp…
a188b34 
…ec.js

Co-Authored-By: Eugene Kashida <ekashida@gmail.com>
@caridy @ekashida
Update packages/integration-karma/test/polyfills/shadow-root/index.sp…
e9ea4f3 
…ec.js

Co-Authored-By: Eugene Kashida <ekashida@gmail.com>
@caridy @ekashida
Update packages/integration-karma/test/polyfills/shadow-root/index.sp…
43b717d 
…ec.js

Co-Authored-By: Eugene Kashida <ekashida@gmail.com>
@caridy
fix(integration-karma): types
f127b5a
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 5e2678c | Target commit: a188b34

lwc-engine-benchmark

table-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/append/1k duration 140.10 (±3.60 ms) 139.50 (±4.35 ms) -0.6ms (0.4%) 👌
table-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/clear/1k duration 10.50 (±0.90 ms) 10.60 (±1.10 ms) +0.1ms (1.0%) 👌
table-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table/create/10k duration 840.30 (±6.20 ms) 853.90 (±4.90 ms) +13.6ms (1.6%) 👎
table-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/create/1k duration 106.50 (±2.30 ms) 107.00 (±2.30 ms) +0.5ms (0.5%) 👌
table-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/update-10th/1k duration 66.75 (±1.75 ms) 67.75 (±2.60 ms) +1.0ms (1.5%) 👌
tablecmp-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/append/1k duration 221.85 (±9.40 ms) 223.50 (±12.15 ms) +1.7ms (0.7%) 👌
tablecmp-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/clear/1k duration 7.20 (±1.25 ms) 7.15 (±1.45 ms) -0.0ms (0.7%) 👌
tablecmp-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/create/10k duration 1625.00 (±8.65 ms) 1590.00 (±13.05 ms) -35.0ms (2.2%) 👍
tablecmp-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/create/1k duration 185.60 (±5.30 ms) 182.15 (±4.20 ms) -3.5ms (1.9%) 👍
tablecmp-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/update-10th/1k duration 66.85 (±5.10 ms) 66.60 (±5.10 ms) -0.3ms (0.4%) 👌
wc-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/append/1k duration 252.20 (±7.10 ms) 256.00 (±8.70 ms) +3.8ms (1.5%) 👌
wc-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/clear/1k duration 11.00 (±2.00 ms) 11.60 (±2.00 ms) +0.6ms (5.5%) 👌
wc-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/create/10k duration 1928.95 (±11.90 ms) 1932.35 (±20.60 ms) +3.4ms (0.2%) 👌
wc-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/create/1k duration 237.15 (±4.65 ms) 238.20 (±4.00 ms) +1.1ms (0.4%) 👌
wc-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/update-10th/1k duration 64.25 (±4.60 ms) 66.60 (±5.40 ms) +2.3ms (3.7%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 5e2678c | Target commit: a188b34

lwc-engine-benchmark

table-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/append/1k duration 140.10 (±3.60 ms) 140.20 (±4.25 ms) +0.1ms (0.1%) 👌
table-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/clear/1k duration 10.50 (±0.90 ms) 9.85 (±0.70 ms) -0.6ms (6.2%) 👍
table-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table/create/10k duration 840.30 (±6.20 ms) 846.90 (±5.55 ms) +6.6ms (0.8%) 👎
table-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/create/1k duration 106.50 (±2.30 ms) 107.75 (±3.00 ms) +1.3ms (1.2%) 👌
table-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table/update-10th/1k duration 66.75 (±1.75 ms) 73.50 (±5.50 ms) +6.8ms (10.1%) 👎
tablecmp-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/append/1k duration 221.85 (±9.40 ms) 224.45 (±10.60 ms) +2.6ms (1.2%) 👌
tablecmp-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/clear/1k duration 7.20 (±1.25 ms) 6.85 (±1.15 ms) -0.4ms (4.9%) 👌
tablecmp-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/create/10k duration 1625.00 (±8.65 ms) 1603.65 (±16.05 ms) -21.3ms (1.3%) 👍
tablecmp-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/create/1k duration 185.60 (±5.30 ms) 183.45 (±4.65 ms) -2.2ms (1.2%) 👌
tablecmp-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-component/update-10th/1k duration 66.85 (±5.10 ms) 66.80 (±5.40 ms) -0.0ms (0.1%) 👌
wc-append-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/append/1k duration 252.20 (±7.10 ms) 250.95 (±9.95 ms) -1.3ms (0.5%) 👌
wc-clear-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/clear/1k duration 11.00 (±2.00 ms) 11.30 (±1.20 ms) +0.3ms (2.7%) 👌
wc-create-10k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/create/10k duration 1928.95 (±11.90 ms) 1956.15 (±12.95 ms) +27.2ms (1.4%) 👎
wc-create-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/create/1k duration 237.15 (±4.65 ms) 237.00 (±4.90 ms) -0.1ms (0.1%) 👌
wc-update-10th-1k metric base(5e2678c) target(a188b34) trend
benchmark-table-wc/update-10th/1k duration 64.25 (±4.60 ms) 65.35 (±5.10 ms) +1.1ms (1.7%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 5e2678c | Target commit: f127b5a

lwc-engine-benchmark

table-append-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table/append/1k duration 140.10 (±3.60 ms) 140.90 (±3.95 ms) +0.8ms (0.6%) 👌
table-clear-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table/clear/1k duration 10.50 (±0.90 ms) 10.25 (±0.90 ms) -0.3ms (2.4%) 👌
table-create-10k metric base(5e2678c) target(f127b5a) trend
benchmark-table/create/10k duration 840.30 (±6.20 ms) 848.60 (±5.95 ms) +8.3ms (1.0%) 👎
table-create-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table/create/1k duration 106.50 (±2.30 ms) 106.60 (±3.00 ms) +0.1ms (0.1%) 👌
table-update-10th-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table/update-10th/1k duration 66.75 (±1.75 ms) 74.40 (±5.10 ms) +7.7ms (11.5%) 👎
tablecmp-append-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-component/append/1k duration 221.85 (±9.40 ms) 225.35 (±10.20 ms) +3.5ms (1.6%) 👌
tablecmp-clear-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-component/clear/1k duration 7.20 (±1.25 ms) 6.65 (±1.20 ms) -0.5ms (7.6%) 👌
tablecmp-create-10k metric base(5e2678c) target(f127b5a) trend
benchmark-table-component/create/10k duration 1625.00 (±8.65 ms) 1648.20 (±7.35 ms) +23.2ms (1.4%) 👎
tablecmp-create-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-component/create/1k duration 185.60 (±5.30 ms) 182.80 (±4.85 ms) -2.8ms (1.5%) 👍
tablecmp-update-10th-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-component/update-10th/1k duration 66.85 (±5.10 ms) 68.90 (±5.40 ms) +2.1ms (3.1%) 👌
wc-append-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-wc/append/1k duration 252.20 (±7.10 ms) 254.35 (±10.70 ms) +2.2ms (0.9%) 👌
wc-clear-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-wc/clear/1k duration 11.00 (±2.00 ms) 11.90 (±1.45 ms) +0.9ms (8.2%) 👌
wc-create-10k metric base(5e2678c) target(f127b5a) trend
benchmark-table-wc/create/10k duration 1928.95 (±11.90 ms) 1940.25 (±13.55 ms) +11.3ms (0.6%) 👎
wc-create-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-wc/create/1k duration 237.15 (±4.65 ms) 239.50 (±4.40 ms) +2.4ms (1.0%) 👌
wc-update-10th-1k metric base(5e2678c) target(f127b5a) trend
benchmark-table-wc/update-10th/1k duration 64.25 (±4.60 ms) 66.90 (±4.60 ms) +2.7ms (4.1%) 👌

@caridy caridy merged commit 64a3f5e into master Jun 3, 2019
@caridy caridy deleted the caridy/test-cleanup-for-separation branch June 3, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekashida ekashida ekashida requested changes

@pmdartus pmdartus pmdartus approved these changes

@ravijayaramappa ravijayaramappa Awaiting requested review from ravijayaramappa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caridy @ekashida @pmdartus