Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HMR] CSS: Provide a mechanism to register stylesheets #1887

Open
ravijayaramappa opened this issue May 22, 2020 · 2 comments
Open

[HMR] CSS: Provide a mechanism to register stylesheets #1887

ravijayaramappa opened this issue May 22, 2020 · 2 comments
Labels
enhancement HMR Hot Module Replacement

Comments

@ravijayaramappa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Adding support for Hot Module Resolution(HMR) requires a registration process to hot swap component constructor, template and stylesheet. Today we have a mechanism to register a template and component constructor as trusted. This feature request is to provide a similar registration mechanism for StyleSheets.

When a new style is being registered for swap, it can be validated before being used.

Describe the solution you'd like
Provide a registerStyleSheet() API from 'lwc' module

Additional context
This requirement originated while reviewing this PR #1860
@nolanlawson nolanlawson changed the title CSS: Provide a mechanism to register stylesheets [HMR] CSS: Provide a mechanism to register stylesheets Aug 8, 2022
@nolanlawson nolanlawson mentioned this issue Nov 10, 2022
Closed
@jye-sf jye-sf mentioned this issue Apr 4, 2023
Merged
@nolanlawson
Copy link
Contributor

Fixed by #3443

@nolanlawson
Copy link
Contributor

This was merged and then reverted. It would be fixed by #3477.

@nolanlawson nolanlawson reopened this Apr 15, 2024
@nolanlawson nolanlawson added the HMR Hot Module Replacement label Apr 18, 2024
@wjhsf wjhsf mentioned this issue May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement HMR Hot Module Replacement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nolanlawson @ravijayaramappa