Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light DOM serialization is incorrect when mixed with synthetic shadow DOM #2425

Closed
pmdartus opened this issue Jul 19, 2021 · 5 comments · Fixed by #2502 or #2549
Closed

Light DOM serialization is incorrect when mixed with synthetic shadow DOM #2425

pmdartus opened this issue Jul 19, 2021 · 5 comments · Fixed by #2502 or #2549
Labels
BUG P3

Comments

@pmdartus
Copy link
Member

Description

The following API report incorrect values when mixing light DOM with synthetic shadow DOM:

  • Node.prototype.textContent
  • Element.prototype.innerHTML
  • Element.prototype.outerHTML

Failing test examples added via #2393

Browsers Affected

All

Version

  • LWC: 2.2.8
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-9630160

nolanlawson added a commit that referenced this issue Sep 21, 2021
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization
66061bc 
Fixes #2425
@nolanlawson nolanlawson mentioned this issue Sep 21, 2021
Merged
nolanlawson added a commit that referenced this issue Oct 8, 2021
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization
40ddf2f 
Fixes #2425
nolanlawson added a commit that referenced this issue Oct 8, 2021
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization (#2502)
9560942 
* fix(synthetic-shadow): fix light DOM serialization

Fixes #2425

* fix: fix deep shadows within light

* fix: get it working in IE11

* fix: fix code comment

* fix: fix code comment

* fix: extract into shared function

* fix: use treewalker

* test: add some more sanity tests for light DOM depth
@nolanlawson nolanlawson reopened this Oct 25, 2021
@nolanlawson
Copy link
Contributor

Reopened due to #2540

nolanlawson added a commit that referenced this issue Oct 25, 2021
@nolanlawson
fix(synthetic-shadow): un-revert serialization fix
84276b9 
Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425
@nolanlawson nolanlawson mentioned this issue Oct 25, 2021
Merged
nolanlawson added a commit that referenced this issue Dec 15, 2021
@nolanlawson
fix(synthetic-shadow): un-revert serialization fix
ec173a7 
Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425
nolanlawson added a commit that referenced this issue Jan 3, 2022
@nolanlawson
fix(synthetic-shadow): un-revert serialization fix
1b3854f 
Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425
@gregwhitworth
Copy link

@nolanlawson @abdulsattar while I haven't gotten any negative feedback is this bug close to landing because this seems like one we should probably ensure devs don't take a dependency on

@nolanlawson
Copy link
Contributor

@gregwhitworth Yep I came to the same conclusion. Planning to merge soon: #2549 (comment)

@nolanlawson nolanlawson mentioned this issue Jan 10, 2022
Closed
nolanlawson added a commit that referenced this issue Jan 11, 2022
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization (#2549)
37b3873 
* fix(synthetic-shadow): un-revert serialization fix

Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425

* fix: fix typescript
@nolanlawson nolanlawson mentioned this issue Jan 14, 2022
Closed
@nolanlawson nolanlawson reopened this Jan 14, 2022
nolanlawson added a commit that referenced this issue Jan 14, 2022
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization (#2549)
3632aa2 
* fix(synthetic-shadow): un-revert serialization fix

Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425

* fix: fix typescript
nolanlawson added a commit that referenced this issue Jan 14, 2022
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization (#2549)
c8f9073 
* fix(synthetic-shadow): un-revert serialization fix

Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425

* fix: fix typescript
nolanlawson added a commit that referenced this issue Jan 14, 2022
@nolanlawson
fix(synthetic-shadow): fix light DOM serialization (#2549)
b97821e 
* fix(synthetic-shadow): un-revert serialization fix

Related: #2502 @W-10059718 #2540

This reverts commit 0de7ef2.

Fixes #2425

* fix: fix typescript
@nolanlawson
Copy link
Contributor

We resolved not to make this change, to avoid breaking current users of synthetic shadow DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG P3
Projects
None yet
Milestone
No milestone
4 participants
@nolanlawson @gregwhitworth @pmdartus @uip-robot-zz