Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze the template object #2782

Closed
nolanlawson opened this issue Apr 11, 2022 · 2 comments
Closed

Freeze the template object #2782

nolanlawson opened this issue Apr 11, 2022 · 2 comments
Labels
enhancement

Comments

@nolanlawson
Copy link
Contributor

Right now it is possible to set the stylesheets/stylesheetToken on a template dynamically in the render() function, as described here and here.

We should block this by freezing the tmpl function object. It introduces unexpected runtime behavior and makes it hard for us to make changes to the engine.
@nolanlawson
Copy link
Contributor Author

WI: W-10950976

@nolanlawson nolanlawson mentioned this issue Apr 11, 2022
Closed
@nolanlawson
Copy link
Contributor Author

Duplicate of #2826

@nolanlawson nolanlawson marked this as a duplicate of #2826 Aug 8, 2022
@wjhsf wjhsf mentioned this issue May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson