Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up post-migration TypeScript in @lwc/babel-plugin-component #3444

Open
nolanlawson opened this issue Apr 5, 2023 · 2 comments · Fixed by #3468
Open

Clean up post-migration TypeScript in @lwc/babel-plugin-component #3444

nolanlawson opened this issue Apr 5, 2023 · 2 comments · Fixed by #3468
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Contributor

nolanlawson commented Apr 5, 2023

Follow-up from #3373. That PR just migrates the code to TypeScript, but there are further improvements we can make to both the code and the types.

E.g.:

@nolanlawson nolanlawson changed the title Improve typechecking in @lwc/babel-plugin-component Clean up post-migration TypeScript in @lwc/babel-plugin-component Apr 5, 2023
@nolanlawson
Copy link
Contributor Author

We should also add JSDoc for these options:

export interface LwcBabelPluginOptions {
isExplicitImport?: boolean;
dynamicImports?: {
loader?: string;
strictSpecifier?: boolean;
};
namespace?: string;
name?: string;
}

@nolanlawson
Copy link
Contributor Author

Reopening as #3468 is a partial fix.

@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant