Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate how to handle invalid unsubscribe functions produced by signal.subscribe #3978

Open
jmsjtu opened this issue Feb 6, 2024 · 0 comments
Open

Evaluate how to handle invalid unsubscribe functions produced by signal.subscribe #3978

jmsjtu opened this issue Feb 6, 2024 · 0 comments
Labels
enhancement

Comments

@jmsjtu
Copy link
Member

jmsjtu commented Feb 6, 2024

The v1 implementation expects a signal's subscribe method to produce an unsubscribe function.

In the current implementation, we silently fail when the unsubscribe is not a function.

We should re-evaluate in 252 how to best handle this scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmsjtu