Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move databag parsing after gathering static elements. #4077

Open
jmsjtu opened this issue Mar 19, 2024 · 0 comments
Open

Move databag parsing after gathering static elements. #4077

jmsjtu opened this issue Mar 19, 2024 · 0 comments
Labels

Comments

@jmsjtu
Copy link
Member

jmsjtu commented Mar 19, 2024

During codegen phase when an element is transformed, we gather the databag before processing static elements.

When an element is identified as static safe, we exit the remainder of the transformElement routine which means didn't need to gather the databag at the start.

We should look into processing the databag until after we check is the element is static safe.

This could remove the need for cloning the expression during static content optimization.

Moving the databag processing also causes tes failures with older api versions such as API_VERSION=58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant