Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-service return shape #48

Closed
yungcheng opened this issue Jan 30, 2018 · 2 comments
Closed

wire-service return shape #48

yungcheng opened this issue Jan 30, 2018 · 2 comments
Labels
question wire-service

Comments

@yungcheng
Copy link
Contributor

original from
#44 (comment)

Whats the reasoning behind using undefined for missing data and null for missing error? Do we even need to include data and error keys at all in these cases?
@yungcheng yungcheng mentioned this issue Feb 13, 2018
Closed
2 tasks
@jbenallen
Copy link

Is this now resolved with decisions implemented in #166 ?

@kevinv11n
Copy link
Contributor

It is resolved: the wire adapter has complete control over the shape it emits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question wire-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevinv11n @jbenallen @yungcheng