Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): checked transformation errors #496

Merged
merged 4 commits into from Jul 12, 2018

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Jul 11, 2018

Details

Fixes #425

Compiler no longer throws during transformation. If an error is encountered, it is collected via diagnostics and returned along with compiler report object. Compilation success will be marked as false. The consumer of the compiler has to always check on the compilation statuss.

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko requested a review from diervo July 11, 2018 21:38
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 704422f | Target commit: e199e56

lwc-engine-benchmark

table-append-1k metric base(704422f) target(e199e56) trend
benchmark-table/append/1k duration 155.90 (± 6.30 ms) 159.70 (± 5.90 ms) -2.44% 👌
table-clear-1k metric base(704422f) target(e199e56) trend
benchmark-table/clear/1k duration 12.50 (± 0.60 ms) 12.30 (± 0.60 ms) 1.60% 👌
table-create-10k metric base(704422f) target(e199e56) trend
benchmark-table/create/10k duration 909.90 (± 7.30 ms) 919.30 (± 11.00 ms) -1.03% 👎
table-create-1k metric base(704422f) target(e199e56) trend
benchmark-table/create/1k duration 104.70 (± 2.10 ms) 104.20 (± 1.60 ms) 0.48% 👌
table-update-10th-1k metric base(704422f) target(e199e56) trend
benchmark-table/update-10th/1k duration 89.30 (± 5.70 ms) 91.10 (± 4.50 ms) -2.02% 👌
tablecmp-append-1k metric base(704422f) target(e199e56) trend
benchmark-table-component/append/1k duration 240.10 (± 3.80 ms) 242.10 (± 3.40 ms) -0.83% 👎
tablecmp-clear-1k metric base(704422f) target(e199e56) trend
benchmark-table-component/clear/1k duration 36.80 (± 1.50 ms) 38.00 (± 1.50 ms) -3.26% 👎
tablecmp-create-10k metric base(704422f) target(e199e56) trend
benchmark-table-component/create/10k duration 1611.60 (± 8.00 ms) 1626.30 (± 14.10 ms) -0.91% 👎
tablecmp-create-1k metric base(704422f) target(e199e56) trend
benchmark-table-component/create/1k duration 174.80 (± 3.50 ms) 175.70 (± 4.30 ms) -0.51% 👌
tablecmp-update-10th-1k metric base(704422f) target(e199e56) trend
benchmark-table-component/update-10th/1k duration 79.90 (± 4.80 ms) 78.80 (± 3.45 ms) 1.38% 👌
wc-append-1k metric base(704422f) target(e199e56) trend
benchmark-table-wc/append/1k duration 256.40 (± 13.00 ms) 276.40 (± 9.30 ms) -7.80% 👎
wc-clear-1k metric base(704422f) target(e199e56) trend
benchmark-table-wc/clear/1k duration 37.50 (± 1.10 ms) 37.90 (± 1.10 ms) -1.07% 👌
wc-create-10k metric base(704422f) target(e199e56) trend
benchmark-table-wc/create/10k duration 2121.70 (± 9.30 ms) 2079.30 (± 8.10 ms) 2.00% 👍
wc-create-1k metric base(704422f) target(e199e56) trend
benchmark-table-wc/create/1k duration 219.90 (± 3.10 ms) 219.40 (± 5.50 ms) 0.23% 👌
wc-update-10th-1k metric base(704422f) target(e199e56) trend
benchmark-table-wc/update-10th/1k duration 79.90 (± 4.40 ms) 78.50 (± 4.60 ms) 1.75% 👌

@apapko apapko requested review from ekashida and removed request for ekashida July 11, 2018 22:24
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3f8c066 | Target commit: f817837

lwc-engine-benchmark

table-append-1k metric base(3f8c066) target(f817837) trend
benchmark-table/append/1k duration 155.20 (± 6.50 ms) 160.80 (± 6.75 ms) -3.61% 👎
table-clear-1k metric base(3f8c066) target(f817837) trend
benchmark-table/clear/1k duration 12.40 (± 0.40 ms) 12.40 (± 0.50 ms) 0.00% 👌
table-create-10k metric base(3f8c066) target(f817837) trend
benchmark-table/create/10k duration 920.60 (± 12.90 ms) 926.50 (± 10.80 ms) -0.64% 👌
table-create-1k metric base(3f8c066) target(f817837) trend
benchmark-table/create/1k duration 107.20 (± 2.40 ms) 104.40 (± 2.30 ms) 2.61% 👍
table-update-10th-1k metric base(3f8c066) target(f817837) trend
benchmark-table/update-10th/1k duration 92.10 (± 4.40 ms) 95.00 (± 4.30 ms) -3.15% 👌
tablecmp-append-1k metric base(3f8c066) target(f817837) trend
benchmark-table-component/append/1k duration 239.10 (± 3.90 ms) 237.50 (± 4.60 ms) 0.67% 👌
tablecmp-clear-1k metric base(3f8c066) target(f817837) trend
benchmark-table-component/clear/1k duration 37.00 (± 1.80 ms) 36.70 (± 1.60 ms) 0.81% 👌
tablecmp-create-10k metric base(3f8c066) target(f817837) trend
benchmark-table-component/create/10k duration 1611.10 (± 11.30 ms) 1647.10 (± 20.70 ms) -2.23% 👎
tablecmp-create-1k metric base(3f8c066) target(f817837) trend
benchmark-table-component/create/1k duration 174.50 (± 2.70 ms) 179.70 (± 4.90 ms) -2.98% 👎
tablecmp-update-10th-1k metric base(3f8c066) target(f817837) trend
benchmark-table-component/update-10th/1k duration 79.95 (± 4.50 ms) 79.60 (± 3.30 ms) 0.44% 👌
wc-append-1k metric base(3f8c066) target(f817837) trend
benchmark-table-wc/append/1k duration 271.10 (± 12.20 ms) 276.90 (± 15.50 ms) -2.14% 👎
wc-clear-1k metric base(3f8c066) target(f817837) trend
benchmark-table-wc/clear/1k duration 38.60 (± 1.10 ms) 40.90 (± 1.30 ms) -5.96% 👎
wc-create-10k metric base(3f8c066) target(f817837) trend
benchmark-table-wc/create/10k duration 2121.80 (± 9.60 ms) 2138.80 (± 10.40 ms) -0.80% 👎
wc-create-1k metric base(3f8c066) target(f817837) trend
benchmark-table-wc/create/1k duration 217.80 (± 5.20 ms) 219.50 (± 2.90 ms) -0.78% 👌
wc-update-10th-1k metric base(3f8c066) target(f817837) trend
benchmark-table-wc/update-10th/1k duration 79.20 (± 3.90 ms) 82.10 (± 6.10 ms) -3.66% 👎

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0ff8ff2 | Target commit: 1a914ee

lwc-engine-benchmark

table-append-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table/append/1k duration 152.80 (± 4.40 ms) 154.10 (± 5.70 ms) -0.85% 👌
table-clear-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table/clear/1k duration 12.40 (± 0.80 ms) 12.30 (± 0.50 ms) 0.81% 👌
table-create-10k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table/create/10k duration 907.20 (± 9.70 ms) 909.00 (± 7.20 ms) -0.20% 👌
table-create-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table/create/1k duration 106.30 (± 1.90 ms) 103.30 (± 2.00 ms) 2.82% 👍
table-update-10th-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table/update-10th/1k duration 91.10 (± 5.40 ms) 88.60 (± 4.70 ms) 2.74% 👌
tablecmp-append-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-component/append/1k duration 233.40 (± 4.40 ms) 235.70 (± 4.90 ms) -0.99% 👌
tablecmp-clear-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-component/clear/1k duration 36.30 (± 1.90 ms) 36.60 (± 1.90 ms) -0.83% 👌
tablecmp-create-10k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-component/create/10k duration 1623.10 (± 13.20 ms) 1611.40 (± 11.50 ms) 0.72% 👍
tablecmp-create-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-component/create/1k duration 175.40 (± 3.10 ms) 173.10 (± 3.00 ms) 1.31% 👌
tablecmp-update-10th-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-component/update-10th/1k duration 76.90 (± 4.20 ms) 79.80 (± 4.20 ms) -3.77% 👌
wc-append-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-wc/append/1k duration 262.00 (± 15.00 ms) 265.90 (± 19.50 ms) -1.49% 👎
wc-clear-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-wc/clear/1k duration 36.30 (± 0.90 ms) 39.20 (± 1.20 ms) -7.99% 👎
wc-create-10k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-wc/create/10k duration 2067.20 (± 8.20 ms) 2093.60 (± 6.40 ms) -1.28% 👎
wc-create-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-wc/create/1k duration 214.10 (± 6.70 ms) 218.50 (± 4.70 ms) -2.06% 👎
wc-update-10th-1k metric base(0ff8ff2) target(1a914ee) trend
benchmark-table-wc/update-10th/1k duration 77.90 (± 5.00 ms) 80.20 (± 5.80 ms) -2.95% 👌

@apapko apapko merged commit d2f6e63 into master Jul 12, 2018
@apapko apapko deleted the apapko/checked-transform-errors branch July 12, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants