Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update babel-minify to fix minification issue #545

Merged
merged 3 commits into from Jul 31, 2018

Conversation

pmdartus
Copy link
Member

Details

This PR fixes known minification issues due to babel-minify. The previous version of the minifier was producing invalid loops in certain cases.

Does this PR introduce a breaking change?

  • Yes
  • No

package.json Outdated
@@ -35,8 +35,7 @@
"@types/acorn": "~4.0.3",
"@types/jest": "~23.0.0",
"@types/node": "8.9.4",
"babel-core": "~7.0.0-0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removing an old version of babel-core present on the root package.json.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed for jest, to make babel functioning correctly. If the test passes maybe now we are good?

@trevor-bliss
Copy link
Contributor

@pmdartus Looks like lwc-engine needs to be updated as well.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: af017c8 | Target commit: 58d32bf

@pmdartus pmdartus force-pushed the pmdartus/fix-wire-service-minification branch from 58d32bf to f31d5fb Compare July 31, 2018 21:06
@trevor-bliss trevor-bliss force-pushed the pmdartus/fix-wire-service-minification branch from f31d5fb to 49a9bf8 Compare July 31, 2018 21:12
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: b3ba230 | Target commit: 49a9bf8

lwc-engine-benchmark

table-append-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table/append/1k duration 144.20 (± 4.30 ms) 146.50 (± 6.10 ms) -1.60% 👌
table-clear-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table/clear/1k duration 11.90 (± 0.45 ms) 12.00 (± 0.70 ms) -0.84% 👌
table-create-10k metric base(b3ba230) target(49a9bf8) trend
benchmark-table/create/10k duration 838.30 (± 4.60 ms) 841.30 (± 5.95 ms) -0.36% 👎
table-create-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table/create/1k duration 102.10 (± 2.10 ms) 100.50 (± 2.50 ms) 1.57% 👍
table-update-10th-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table/update-10th/1k duration 83.00 (± 4.90 ms) 88.00 (± 5.60 ms) -6.02% 👌
tablecmp-append-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-component/append/1k duration 225.40 (± 4.00 ms) 221.85 (± 5.75 ms) 1.57% 👍
tablecmp-clear-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-component/clear/1k duration 34.80 (± 2.40 ms) 35.40 (± 2.15 ms) -1.72% 👌
tablecmp-create-10k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-component/create/10k duration 1541.50 (± 15.35 ms) 1543.70 (± 5.60 ms) -0.14% 👌
tablecmp-create-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-component/create/1k duration 168.10 (± 5.50 ms) 170.00 (± 2.40 ms) -1.13% 👌
tablecmp-update-10th-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-component/update-10th/1k duration 78.30 (± 4.40 ms) 78.20 (± 3.90 ms) 0.13% 👌
wc-append-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-wc/append/1k duration 255.10 (± 12.60 ms) 255.60 (± 11.60 ms) -0.20% 👌
wc-clear-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-wc/clear/1k duration 35.70 (± 1.50 ms) 36.40 (± 1.20 ms) -1.96% 👌
wc-create-10k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-wc/create/10k duration 1998.40 (± 7.30 ms) 1990.70 (± 7.10 ms) 0.39% 👍
wc-create-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-wc/create/1k duration 213.20 (± 4.60 ms) 212.70 (± 4.50 ms) 0.23% 👌
wc-update-10th-1k metric base(b3ba230) target(49a9bf8) trend
benchmark-table-wc/update-10th/1k duration 75.50 (± 3.90 ms) 75.50 (± 3.70 ms) 0.00% 👌

Copy link
Contributor

@diervo diervo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we push the new version everywhere, ship it

@pmdartus pmdartus merged commit 3c68a69 into master Jul 31, 2018
@pmdartus pmdartus deleted the pmdartus/fix-wire-service-minification branch July 31, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants