feat: dynamic scoped ids #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
ekashida
force-pushed
the
scoped-ids
branch
2 times, most recently
from
a8d1573
to
c390247
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
Nov 1, 2018
| @@ -592,6 +592,17 @@ export function k(compilerKey: number, obj: any): number | string | void { | |||
| } | |||
|
|
|||
| // [g]lobal [id] function | |||
| export function gid(id: string): string { | |||
| export function gid(id: any): string | null | undefined { | |||
| if (isNull(id) || isUndefined(id)) { | |||
There was a problem hiding this comment.
probably faster to do == null
There was a problem hiding this comment.
Sorry for the n00b question, but what when does == null evaluate to true?
caridy
reviewed
Nov 1, 2018
| export function gid(id: string): string { | ||
| export function gid(id: any): string | null | undefined { | ||
| if (isNull(id) || isUndefined(id)) { | ||
| // - Custom elements: `id="null"` and `id="undefined"` |
There was a problem hiding this comment.
what about the error? assert.logError()
caridy
reviewed
Nov 1, 2018
| return id; | ||
| } | ||
| if (isString(id) && !id.length) { | ||
| // - Empty strings will render a boolean attribute: `id` |
caridy
reviewed
Nov 1, 2018
| // - Native elements will not render the id attribute | ||
| return id; | ||
| } | ||
| if (isString(id) && !id.length) { |
There was a problem hiding this comment.
maybe we can move this into the previous condition, saying (id == null || id === '') return the same id
ekashida
commented
Nov 8, 2018
| export function gid(id: any): string | null | undefined { | ||
| if (isNull(id) || isUndefined(id) || id === '') { | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| assert.logError(`Invalid id value "${id}". Expected a non-empty string.`, vmBeingRendered!.elm); |
There was a problem hiding this comment.
Not too sure about this vmBeingRendered!.elm.
caridy
approved these changes
Nov 8, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change?