feat: no production assert tslint rule

[jodarove]

Details

We should strip asserts when compiling the framework code for production environment.
For that the assertion code should be wrapped in: if (process.env.NODE_ENV === 'production') {}.

This pr adds a tslint rule to ensure this.

Does this PR introduce a breaking change?

• Yes
• No

[jodarove]

@pmdartus @ekashida @caridy : your feedback in #889 is addressed in this pr. thanks!

[pmdartus]

Small style detail. But except that LGTM

[pmdartus]

Another approach to tackle this issue would be to lint the generated production code instead of the dev code. It would alleviate the need to add tslint inline comments for the functions that we know will be stripped in PROD (very fragile).

@jodarove Thoughts?

[caridy]

Ok, I'm fine with this as it is!

[jodarove]

Another approach to tackle this issue would be to lint the generated production code instead of the dev code. It would alleviate the need to add tslint inline comments for the functions that we know will be stripped in PROD (very fragile).

@jodarove Thoughts?

@pmdartus i agree that we should add a check (some how) in the generated production code to verify no asserts are leaking before it actually gets to prod, which is a late.

That being said, this pr addresses a different issue, is meant to give an early feedback to devs that they might be leaking asserts to prod, trusting that the ci lint phase will fail and the build process of the prod scripts will do the work stripping what is wrapped in the if condition.

[ekashida]

Curious where the tests went? Were they difficult to put into place after moving the rules inside engine?

[jodarove]

@pmdartus @caridy @ekashida : before merging, pick your poison: this way or #898

[jodarove]

@ekashida you dont miss one eh? :)

I was having an issue with jest generating the coverage (without coverage is fine), in order to run the tests in the script/rules folder, a new entry needs to be added in roots from jest.config.js, adding this was causing an exception when generating the coverage. this investigation will take time, though i can add the tests from tslint if you feel more confident.