Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit metadata plumbing in babel-plugin-transform-lwc-class #96

Closed
yungcheng opened this issue Feb 13, 2018 · 4 comments
Closed

Revisit metadata plumbing in babel-plugin-transform-lwc-class #96

yungcheng opened this issue Feb 13, 2018 · 4 comments

Comments

@yungcheng
Copy link
Contributor

Description

A follow up for #88, we currently use state.file.metadata to keep track of compiler metadata. However, state.file is internal api of babel and could change in the future. When it changes, our implementation would not work as expected.

We've also explored using plugin config option for compiler metadata bookkeeping but Babel has issues logged to cache config so that alternative isn't future safe either.

We need to have a proper future safe way for compiler metadata bookkeeping during plugin transform.

@pmdartus pmdartus self-assigned this Feb 13, 2018
@pmdartus pmdartus removed their assignment Feb 13, 2018
@apapko
Copy link
Collaborator

apapko commented Feb 13, 2018

We need to add support for multi-class metadata.

@caridy
Copy link
Contributor

caridy commented Nov 23, 2018

Is this still a thing to do @apapko ?

@caridy caridy closed this as completed Nov 23, 2018
@caridy caridy reopened this Nov 23, 2018
@pmdartus
Copy link
Member

This is still a think, there is a laundry list of all the technical debt that we have accumulated over the year in the compiler. Metadata gathering during the transformation is one of those.

@pmdartus
Copy link
Member

The @lwc/babel-plugin-component doesn't gather metadata anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants