Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] [object:vm undefined (0)] is set to a non-trackable object - confuses developers #995

Closed
apapko opened this issue Jan 22, 2019 · 1 comment

Comments

@apapko
Copy link
Collaborator

apapko commented Jan 22, 2019

Description

The error message for the non-trackable object confuses developers. We need to enhance this message to ensure that the intent of the warning is clear. Here is a primitive repro:
https://playground.lwcjs.org/projects/Cw4rnCPsc/3/edit

I think the intent of the message is good in a way that it lets our users know that the received value will never change and that they may want to ensure that the passed value is should indeed not be tracked or be public.

@apapko
Copy link
Collaborator Author

apapko commented Jan 22, 2019

Talked to @caridy and we've decided to remove the warning to eliminate the confusion. The object mutation will result in an error in dev mode, however, in production it will be a noop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant