Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prophet.resample_time_stamps bug #112

Merged

Conversation

rafaelleinio
Copy link
Contributor

Why?

When giving time_stamps=1 for method Prophet.resample_time_stamps, it returns an empty np array.

What?

This PR fixes a bug on the resample_time_stamps method in the Prophet class when passing an integer to the time_stamps arg.

How?

  • Fix the value passed to periods argument in pd.date_range function.
  • Add new unit test for Prophet.resample_time_stamps asserting this functionality

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @rafaelleinio to sign the Salesforce.com Contributor License Agreement.

@aadyotb
Copy link
Contributor

aadyotb commented Jul 14, 2022

Hi @rafaelleinio, thanks for the contribution! Can you sign our CLA so I can get the PR merged?

@rafaelleinio
Copy link
Contributor Author

Hi @rafaelleinio, thanks for the contribution! Can you sign our CLA so I can get the PR merged?

@aadyotb I followed the instructions but I got into an error message. Now when I try to sign again it says that I have already signed. Idk what happened to be honest, can you help me with that? 😅

@aadyotb aadyotb closed this Jul 14, 2022
@aadyotb aadyotb reopened this Jul 14, 2022
@aadyotb
Copy link
Contributor

aadyotb commented Jul 14, 2022

@rafaelleinio I think I just needed to close and re-open the PR. The CLA looks all good now :)

@aadyotb aadyotb merged commit 7047d12 into salesforce:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants