fix: Add global this value lookup to enable node support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
changed the title
caridy
reviewed
Mar 4, 2019
| @@ -67,18 +63,32 @@ const formatter: DevToolFormatter = { | |||
| } | |||
| }; | |||
|
|
|||
| // Inspired from paulmillr/es6-shim | |||
| // https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L176-L185 | |||
| function getGlobal(): any { | |||
There was a problem hiding this comment.
I'm fine with this! Maybe it is also time to start doing globalThis (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis) as part of this condition.
caridy
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global object lookup to not only rely on the
windowobject but alsoglobal(node) andself(web worker).Fix #29