-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update dependencies and fix types for Proxy #66
Conversation
@@ -40,7 +40,8 @@ function rollupConfig({ formats, prod }) { | |||
format, | |||
banner, | |||
footer, | |||
file: path.join(targetDirectory, targetName) | |||
file: path.join(targetDirectory, targetName), | |||
exports: 'auto' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem to change the output file format, and suppresses a warning from Rollup.
d07cfac
to
a40cf15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks otherwise LGTM.
yarn.lock
Outdated
@@ -9,11 +9,23 @@ | |||
dependencies: | |||
"@babel/highlight" "^7.12.13" | |||
|
|||
"@babel/code-frame@^7.14.5": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend running yarn upgrade
to get rid of the duplicate packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>
Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>
Updates dependencies, most notably TypeScript which has a new definition for Proxy objects which breaks some of our existing types: microsoft/TypeScript#35594
Notably it looks like we've been assuming that
PropertyKey
(which isstring | number | symbol
) is fine to be used as proxy property keys, when actually the spec only allowsstring | symbol
. So I added aProxyPropertyKey
type to handle this.