Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeguards to deter people from making any changes to commit message formats #62

Open
twarit-waikar opened this issue Jan 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@twarit-waikar
Copy link
Contributor

  1. Add a comment here that says the changing the commit message format is a significant change which needs to be evaluated by code owners. The blast radius of changing this format needs to be contained in a single location.
    std::string commitMsg = cl + " - " + desc + "\n[p4-fusion: depot-paths = \"" + depotPath.substr(0, depotPath.size() - 3) + "\": change = " + cl + "]";
  2. Add tests the try to detect if a change in the commit message format has been made and if it is a valid change.
@twarit-waikar twarit-waikar added the enhancement New feature or request label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant