Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for providing Classpath index file in executable jar #33

Closed
plaird opened this issue Jul 23, 2020 · 3 comments
Closed

Add attribute for providing Classpath index file in executable jar #33

plaird opened this issue Jul 23, 2020 · 3 comments

Comments

@plaird
Copy link
Contributor

plaird commented Jul 23, 2020

Some newer features of Spring Boot executable jar file format are not available in the Bazel Spring Boot jar rule yet.

  • Classpath index file
  • Layer index file

https://docs.spring.io/spring-boot/docs/current/reference/html/appendix-executable-jar-format.html#executable-jar-war-index-files-classpath

This issue is only for the classpath index file. The layer index file is more involved and will be covered in another issue.

I don't think we should do anything magical here (i.e. auto-generating these files). Just allow the user to specify existing workspace files as attributes in the rule.

@plaird
Copy link
Contributor Author

plaird commented Dec 14, 2020

We just had an internal use case come up that requires the classpath.idx file, so we are moving this up into the next minor release train (1.1).

@plaird plaird self-assigned this Dec 14, 2020
@plaird plaird changed the title Add attributes for specifying Classpath and Layer index files in executable jar Add attribute for providing Classpath index file in executable jar Dec 16, 2020
@plaird
Copy link
Contributor Author

plaird commented Dec 16, 2020

This is implemented as you can provide the classpath.idx file and it is inserted correctly into the executable jar, but I am not convinced yet that it actually works. Perhaps I misunderstand the Spring Boot feature.

I also need to document this.

@plaird
Copy link
Contributor Author

plaird commented Dec 16, 2020

Docs were provided in PR #70, closing.

@plaird plaird closed this as completed Dec 16, 2020
Release 1.1: many small improvements automation moved this from To do to Done Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant