Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure workspace specific defaults for springboot rule #78

Open
plaird opened this issue Jan 5, 2021 · 0 comments
Open
Projects

Comments

@plaird
Copy link
Contributor

plaird commented Jan 5, 2021

As a user of the springboot rule
I would like to be able to override the rule's defaults for my workspace to suit my preferences
Such that I can force default dupeclassescheck_enable=True (and other features) on all usages within my Bazel workspace

Background:
As rule authors, we decided on defaults for the various features supported by our rule.
Our default of dupeclassescheck_enable = False is the most notable.
We set our defaults to be user friendly for new users; enabling fail on duplicates by default could be an annoyance for new users.
We allow each usage of the rule to override these defaults as desired using the rule attributes.

But it would be nice (as we are seeing in an internal workspace of ours) to be able to globally (within the workspace) override the default. In our particular case, to enable dupe class checking by default.
Other attributes that could benefit from this treatment include deps_exclude, deps_use_starlark_order, tags, visibility.

The right time to do this is when working #30 since this will likely require backwards incompatible changes to the way the rule is loaded in WORKSPACe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
Awaiting triage
Development

No branches or pull requests

1 participant