Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GitHub repo from bazel-springboot-rule to rules_spring #97

Closed
plaird opened this issue Mar 17, 2021 · 0 comments
Closed

Rename GitHub repo from bazel-springboot-rule to rules_spring #97

plaird opened this issue Mar 17, 2021 · 0 comments

Comments

@plaird
Copy link
Contributor

plaird commented Mar 17, 2021

This is a necessary final step for #30 The Git repo naming convention dictated by Bazel for public rules is rules_technology, where technology for our case is Spring. So our repo should be rules_spring. (note the underscore not a hyphen).

Up until recently, our scope was just springboot, so the rename could be rules_springboot. But if we implement #93 (SpringNative) we cover more than just Spring Boot in Bazel. So naming our repo rules_spring seems to be the right long term move.

I have done some local testing using a test repo, and here is what I found when we rename this repo:

  • anyone using the old name over HTTP will get a 301 redirect to the repo with the new name
  • Bazel http_repository rule follows redirects transparently
  • Bazel git_repository rule follows redirects transparently if you use http as the protocol
  • Bazel git_repository rule follows redirects transparently if you use ssh/git as the protocol
  • browsers, of course, follow redirects transparently

Therefore, the GitHub repo rename should be transparent to all builds and existing documentation links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant