Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing deliverable code for @sa11y/jest@4.0.0 #233

Closed
pozil opened this issue Oct 21, 2022 · 2 comments
Closed

Missing deliverable code for @sa11y/jest@4.0.0 #233

pozil opened this issue Oct 21, 2022 · 2 comments

Comments

@pozil
Copy link

pozil commented Oct 21, 2022

Hi we're using @sa11y/jest in the LWC Recipes sample app and updating to v4.0.0 breaks the import of the Sally Jest matchers:

import { registerSa11yMatcher } from '@sa11y/jest';

Can you document the upgrade process to v3 to v4?
@pozil
Copy link
Author

pozil commented Nov 16, 2022

It turns out that this is a bigger problem: the deliverable code is missing from the 4.0.0 release:
Screen Shot 2022-11-16 at 10 40 54

@pozil pozil changed the title Undocumented breaking change in @sa11y/jest@4.0.0: missing registerSa11yMatcher import Missing deliverable code for @sa11y/jest@4.0.0 Nov 16, 2022
@pozil
Copy link
Author

pozil commented Nov 17, 2022

Fixed in 4.0.1 by #262

@pozil pozil closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pozil