-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out all common spark/hadoop properties #87
Comments
Hey @gerashegalov In order to keep a single spark.gradle file, can we simply replace the PS. I'm fairly new to the project. Pardon me if I'm missing something. 😅 |
Hi @py-ranoid, thanks for looking into this issue. It makes sense, however if possible we should strive to use absolute paths built from project properties (to avoid dealing with relative path attacks with symlinks etc). |
How about keeping keeping only |
@tovbinm @gerashegalov Could you suggest a solution?
|
since |
@gerashegalov In that case, can I replace Also, I noticed that the following are duplicates too.
Would you suggest factoring these out as well ? |
@gerashegalov @tovbinm Thoughts? |
Hi @py-ranoid I suggest you try it out and don't hesitate to submit a PR. We can discuss it more concretely on the PR. It does not have to be perfect, just something to iterate on. The preference is to avoid '..' |
Problem
We currently largely overlapping spark.gradle files especially in terms of spark properties.
Solution
Provide a way to have a single spark.gradle or at least a single spark-transmogrifai.conf file with common properties that is passed via
--properties-file
to Spark.Alternatives
Additional context
DRY
The text was updated successfully, but these errors were encountered: